Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(290)

Issue 1799233003: Ship ES2015 restrictions on function declaration locations (Closed)

Created:
4 years, 9 months ago by Dan Ehrenberg
Modified:
4 years, 9 months ago
Reviewers:
adamk
CC:
Michael Hablich, v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Ship ES2015 restrictions on function declaration locations Function declarations were previously permitted by V8 in many locations which no ECMAScript specification allowed; the ECMAScript 2015 spec enumerates a few locations (in blocks, as well as after labels and in conditionals when in sloppy mode). This patch ships the flag to restrict the usage of function declarations to those contexts. R=adamk LOG=Y BUG=v8:4824 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_chromium_rel_ng;tryserver.blink:linux_blink_rel Committed: https://crrev.com/f9db79ebdb5ab2dd559b5070d905332e489c15ec Cr-Commit-Position: refs/heads/master@{#34828}

Patch Set 1 #

Patch Set 2 : Update tests #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -2 lines) Patch
M src/flag-definitions.h View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M test/mjsunit/regress/regress-220.js View 1 1 chunk +2 lines, -0 lines 0 comments Download
M test/mjsunit/regress/regress-536751.js View 1 1 chunk +1 line, -0 lines 0 comments Download
M test/mjsunit/regress/regress-542099.js View 1 1 chunk +1 line, -0 lines 0 comments Download
M test/mjsunit/regress/regress-542100.js View 1 1 chunk +1 line, -0 lines 0 comments Download
M test/webkit/fast/js/parser-syntax-check.js View 1 1 chunk +2 lines, -0 lines 0 comments Download
M test/webkit/function-declaration-statement.js View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 21 (10 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1799233003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1799233003/1
4 years, 9 months ago (2016-03-15 00:56:33 UTC) #2
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_linux64_avx2_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel/builds/11608)
4 years, 9 months ago (2016-03-15 01:13:45 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1799233003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1799233003/20001
4 years, 9 months ago (2016-03-15 23:48:16 UTC) #6
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_linux64_asan_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel/builds/15291) v8_linux64_avx2_rel on ...
4 years, 9 months ago (2016-03-15 23:49:27 UTC) #8
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1799233003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1799233003/40001
4 years, 9 months ago (2016-03-16 00:49:45 UTC) #10
Dan Ehrenberg
4 years, 9 months ago (2016-03-16 01:12:31 UTC) #11
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 9 months ago (2016-03-16 02:40:26 UTC) #14
adamk
lgtm These restrictions were also present in ES2015, right? I find referring to it as ...
4 years, 9 months ago (2016-03-16 16:08:59 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1799233003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1799233003/40001
4 years, 9 months ago (2016-03-16 16:37:13 UTC) #18
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 9 months ago (2016-03-16 16:39:14 UTC) #19
commit-bot: I haz the power
4 years, 9 months ago (2016-03-16 16:39:33 UTC) #21
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/f9db79ebdb5ab2dd559b5070d905332e489c15ec
Cr-Commit-Position: refs/heads/master@{#34828}

Powered by Google App Engine
This is Rietveld 408576698