content/browser/power_monitor_message_broadcaster.cc - Issue 179923006: Attempting to resolve a race condition with PowerMonitor

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/power_monitor_message_broadcaster.cc

Issue 179923006: Attempting to resolve a race condition with PowerMonitor (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/power_monitor_message_broadcaster.cc

diff --git a/content/browser/power_monitor_message_broadcaster.cc b/content/browser/power_monitor_message_broadcaster.cc

index 23de161b05c7225af72b1efb3dcd45c8545c879f..b1f762794f49b66ae6a47476bfa630a4357bde74 100644

--- a/content/browser/power_monitor_message_broadcaster.cc

+++ b/content/browser/power_monitor_message_broadcaster.cc

@@ -13,15 +13,11 @@ namespace content {

PowerMonitorMessageBroadcaster::PowerMonitorMessageBroadcaster(

IPC::Sender* sender)

: sender_(sender) {

- base::PowerMonitor* power_monitor = base::PowerMonitor::Get();

- if (power_monitor)

- power_monitor->AddObserver(this);

+ base::PowerMonitor::AddObserverThreadSafe(this);

}

PowerMonitorMessageBroadcaster::~PowerMonitorMessageBroadcaster() {

- base::PowerMonitor* power_monitor = base::PowerMonitor::Get();

- if (power_monitor)

- power_monitor->RemoveObserver(this);

+ base::PowerMonitor::RemoveObserverThreadSafe(this);

}

void PowerMonitorMessageBroadcaster::OnPowerStateChange(bool on_battery_power) {