Attempting to resolve a race condition with PowerMonitor

base/power_monitor/power_monitor_source.cc

Index: base/power_monitor/power_monitor_source.cc
diff --git a/base/power_monitor/power_monitor_source.cc b/base/power_monitor/power_monitor_source.cc
index 6868cb19e338e17b7d5c960b606b8f22845893da..33f3d23d9a295244fc08160b84c2a61aaa01c08f 100644
--- a/base/power_monitor/power_monitor_source.cc
+++ b/base/power_monitor/power_monitor_source.cc
@@ -22,11 +22,11 @@ bool PowerMonitorSource::IsOnBatteryPower() {
 }
 
 void PowerMonitorSource::ProcessPowerEvent(PowerEvent event_id) {

[willchan no longer on Chromium, 2014/04/03 23:43:33]

Do we need to update the comments in power_monitor_source.h about which thread
this can be called on?

-  PowerMonitor* monitor = PowerMonitor::Get();
-  if (!monitor)
+  AutoLock lock(*PowerMonitor::GetLock());
+  if (!PowerMonitor::IsInitializedLocked())
     return;
 
-  PowerMonitorSource* source = monitor->Source();
+  PowerMonitorSource* source = PowerMonitor::GetSource();
 
   // Suppress duplicate notifications.  Some platforms may
   // send multiple notifications of the same event.
@@ -45,19 +45,19 @@ void PowerMonitorSource::ProcessPowerEvent(PowerEvent event_id) {
         }
 
         if (changed)
-          monitor->NotifyPowerStateChange(new_on_battery_power);
+          PowerMonitor::NotifyPowerStateChange(new_on_battery_power);
       }
       break;
     case RESUME_EVENT:
       if (source->suspended_) {
         source->suspended_ = false;
-        monitor->NotifyResume();
+        PowerMonitor::NotifyResume();
       }
       break;
     case SUSPEND_EVENT:
       if (!source->suspended_) {
         source->suspended_ = true;
-        monitor->NotifySuspend();
+        PowerMonitor::NotifySuspend();
       }
       break;
   }