Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Side by Side Diff: content/child/power_monitor_broadcast_source_unittest.cc

Issue 179923006: Attempting to resolve a race condition with PowerMonitor (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Refactored to a more explicitly singleton-like style. Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/message_loop/message_loop.h" 5 #include "base/message_loop/message_loop.h"
6 #include "base/test/power_monitor_test_base.h" 6 #include "base/test/power_monitor_test_base.h"
7 #include "content/child/power_monitor_broadcast_source.h" 7 #include "content/child/power_monitor_broadcast_source.h"
8 #include "content/common/power_monitor_messages.h" 8 #include "content/common/power_monitor_messages.h"
9 #include "testing/gtest/include/gtest/gtest.h" 9 #include "testing/gtest/include/gtest/gtest.h"
10 10
11 namespace content { 11 namespace content {
12 12
13 class PowerMonitorBroadcastSourceTest : public testing::Test { 13 class PowerMonitorBroadcastSourceTest : public testing::Test {
14 protected: 14 protected:
15 PowerMonitorBroadcastSourceTest() { 15 PowerMonitorBroadcastSourceTest() {
16 power_monitor_source_ = new PowerMonitorBroadcastSource(); 16 power_monitor_source_ = new PowerMonitorBroadcastSource();
17 power_monitor_.reset(new base::PowerMonitor( 17 base::PowerMonitor::Initialize(
18 scoped_ptr<base::PowerMonitorSource>(power_monitor_source_))); 18 scoped_ptr<base::PowerMonitorSource>(power_monitor_source_));
19 } 19 }
20 virtual ~PowerMonitorBroadcastSourceTest() {} 20 virtual ~PowerMonitorBroadcastSourceTest() { base::PowerMonitor::Shutdown(); }
21 21
22 PowerMonitorBroadcastSource* source() { return power_monitor_source_; } 22 PowerMonitorBroadcastSource* source() { return power_monitor_source_; }
23 base::PowerMonitor* monitor() { return power_monitor_.get(); }
24 23
25 base::MessageLoop message_loop_; 24 base::MessageLoop message_loop_;
26 25
27 private: 26 private:
28 PowerMonitorBroadcastSource* power_monitor_source_; 27 PowerMonitorBroadcastSource* power_monitor_source_;
29 scoped_ptr<base::PowerMonitor> power_monitor_;
30 28
31 DISALLOW_COPY_AND_ASSIGN(PowerMonitorBroadcastSourceTest); 29 DISALLOW_COPY_AND_ASSIGN(PowerMonitorBroadcastSourceTest);
32 }; 30 };
33 31
34 TEST_F(PowerMonitorBroadcastSourceTest, PowerMessageReceiveBroadcast) { 32 TEST_F(PowerMonitorBroadcastSourceTest, PowerMessageReceiveBroadcast) {
35 IPC::ChannelProxy::MessageFilter* message_filter = 33 IPC::ChannelProxy::MessageFilter* message_filter =
36 source()->GetMessageFilter(); 34 source()->GetMessageFilter();
37 35
38 base::PowerMonitorTestObserver observer; 36 base::PowerMonitorTestObserver observer;
39 monitor()->AddObserver(&observer); 37 base::PowerMonitor::AddObserver(&observer);
40 38
41 PowerMonitorMsg_Suspend suspend_msg; 39 PowerMonitorMsg_Suspend suspend_msg;
42 PowerMonitorMsg_Resume resume_msg; 40 PowerMonitorMsg_Resume resume_msg;
43 41
44 // Sending resume when not suspended should have no effect. 42 // Sending resume when not suspended should have no effect.
45 message_filter->OnMessageReceived(resume_msg); 43 message_filter->OnMessageReceived(resume_msg);
46 message_loop_.RunUntilIdle(); 44 message_loop_.RunUntilIdle();
47 EXPECT_EQ(observer.resumes(), 0); 45 EXPECT_EQ(observer.resumes(), 0);
48 46
49 // Pretend we suspended. 47 // Pretend we suspended.
(...skipping 36 matching lines...) Expand 10 before | Expand all | Expand 10 after
86 EXPECT_EQ(observer.power_state_changes(), 2); 84 EXPECT_EQ(observer.power_state_changes(), 2);
87 EXPECT_EQ(observer.last_power_state(), false); 85 EXPECT_EQ(observer.last_power_state(), false);
88 86
89 // Repeated indications the device is off battery power should be suppressed. 87 // Repeated indications the device is off battery power should be suppressed.
90 message_filter->OnMessageReceived(off_battery_msg); 88 message_filter->OnMessageReceived(off_battery_msg);
91 message_loop_.RunUntilIdle(); 89 message_loop_.RunUntilIdle();
92 EXPECT_EQ(observer.power_state_changes(), 2); 90 EXPECT_EQ(observer.power_state_changes(), 2);
93 } 91 }
94 92
95 } // namespace base 93 } // namespace base
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698