Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(296)

Side by Side Diff: base/power_monitor/power_monitor.h

Issue 179923006: Attempting to resolve a race condition with PowerMonitor (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Refactored to a more explicitly singleton-like style. Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | base/power_monitor/power_monitor.cc » ('j') | base/power_monitor/power_monitor.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef BASE_POWER_MONITOR_POWER_MONITOR_H_ 5 #ifndef BASE_POWER_MONITOR_POWER_MONITOR_H_
6 #define BASE_POWER_MONITOR_POWER_MONITOR_H_ 6 #define BASE_POWER_MONITOR_POWER_MONITOR_H_
7 7
8 #include "base/base_export.h" 8 #include "base/base_export.h"
9 #include "base/basictypes.h" 9 #include "base/basictypes.h"
10 #include "base/memory/ref_counted.h" 10 #include "base/memory/ref_counted.h"
11 #include "base/observer_list_threadsafe.h" 11 #include "base/observer_list_threadsafe.h"
12 #include "base/power_monitor/power_observer.h" 12 #include "base/power_monitor/power_observer.h"
13 #include "base/synchronization/lock.h"
13 14
14 namespace base { 15 namespace base {
15 16
16 class PowerMonitorSource; 17 class PowerMonitorSource;
17 18
18 // A class used to monitor the power state change and notify the observers about 19 // A class used to monitor the power state change and notify the observers about
19 // the change event. 20 // the change event.
20 class BASE_EXPORT PowerMonitor { 21 class BASE_EXPORT PowerMonitor {
21 public: 22 public:
22 // Takes ownership of |source|. 23 // Takes ownership of |source|.
23 explicit PowerMonitor(scoped_ptr<PowerMonitorSource> source); 24 static void Initialize(scoped_ptr<PowerMonitorSource> source);
24 ~PowerMonitor(); 25 static void Shutdown();
25 26
26 // Get the process-wide PowerMonitor (if not present, returns NULL). 27 // Has the PowerMonitor already been initialized?
27 static PowerMonitor* Get(); 28 static bool IsInitialized();
28 29
29 // Add and remove an observer. 30 // Add and remove an observer.
30 // Can be called from any thread. 31 // Can be called from any thread.
31 // Must not be called from within a notification callback. 32 // Must not be called from within a notification callback.
32 void AddObserver(PowerObserver* observer); 33 static bool AddObserver(PowerObserver* observer);
33 void RemoveObserver(PowerObserver* observer); 34 static bool RemoveObserver(PowerObserver* observer);
34 35
35 // Is the computer currently on battery power. 36 // Is the computer currently on battery power.
36 bool IsOnBatteryPower(); 37 static bool IsOnBatteryPower();
37 38
38 private: 39 private:
40 explicit PowerMonitor(scoped_ptr<PowerMonitorSource> source);
41 ~PowerMonitor();
39 friend class PowerMonitorSource; 42 friend class PowerMonitorSource;
40 43
44 static Lock* GetSingletonLock();
45 // Must manually aqcuire the lock before calling
46 static PowerMonitor* GetSingleton();
47
48 void AddObserverImpl(PowerObserver* observer);
49 void RemoveObserverImpl(PowerObserver* observer);
50 // Is the computer currently on battery power.
51 bool IsOnBatteryPowerImpl();
52
41 PowerMonitorSource* Source(); 53 PowerMonitorSource* Source();
42 54
43 void NotifyPowerStateChange(bool battery_in_use); 55 void NotifyPowerStateChange(bool battery_in_use);
44 void NotifySuspend(); 56 void NotifySuspend();
45 void NotifyResume(); 57 void NotifyResume();
46 58
47 scoped_refptr<ObserverListThreadSafe<PowerObserver> > observers_; 59 scoped_refptr<ObserverListThreadSafe<PowerObserver> > observers_;
48 scoped_ptr<PowerMonitorSource> source_; 60 scoped_ptr<PowerMonitorSource> source_;
49 61
50 DISALLOW_COPY_AND_ASSIGN(PowerMonitor); 62 DISALLOW_COPY_AND_ASSIGN(PowerMonitor);
51 }; 63 };
52 64
53 } // namespace base 65 } // namespace base
54 66
55 #endif // BASE_POWER_MONITOR_POWER_MONITOR_H_ 67 #endif // BASE_POWER_MONITOR_POWER_MONITOR_H_
OLDNEW
« no previous file with comments | « no previous file | base/power_monitor/power_monitor.cc » ('j') | base/power_monitor/power_monitor.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698