[Extensions] Fix BrowserActionInteractiveTest.TabSwitchClosesPopup

[Extensions] Fix BrowserActionInteractiveTest.TabSwitchClosesPopup

BUG=594417
Committed: https://crrev.com/3dbedd030a19e84b9f5cc366daea1ea20556d5c0
Cr-Commit-Position: refs/heads/master@{#381125}

[Devlin, 2016-03-14 21:21:33]

rdevlin.cronin@chromium.org changed reviewers:
+ asargent@chromium.org

[Devlin, 2016-03-14 21:21:34]

Another one for you.  See the bug for context (this test fails on win8/etc) and
PatchSet 1 for the tryjob against win8.

https://codereview.chromium.org/1799223002/diff/20001/chrome/browser/extensio...
File
chrome/browser/extensions/api/extension_action/browser_action_interactive_test.cc
(left):

https://codereview.chromium.org/1799223002/diff/20001/chrome/browser/extensio...
chrome/browser/extensions/api/extension_action/browser_action_interactive_test.cc:294:
ASSERT_TRUE(ui_test_utils::SendKeyPressSync(
This strikes me as wrong in case this shortcut is ever not recognized on all
platforms.

[asargent_no_longer_on_chrome, 2016-03-14 23:11:24]

lgtm

https://codereview.chromium.org/1799223002/diff/20001/chrome/browser/extensio...
File
chrome/browser/extensions/api/extension_action/browser_action_interactive_test.cc
(right):

https://codereview.chromium.org/1799223002/diff/20001/chrome/browser/extensio...
chrome/browser/extensions/api/extension_action/browser_action_interactive_test.cc:301:

Is there any easy way to verify that the actual
NOTIFICATION_EXTENSION_HOST_DESTROYED observed was for the one we caused to
popup, and not some other random one that might have been created and destroyed
for an unrelated reason? (Maybe looking at the actual source passed to the
observer?) If this is tricky it's probably not worth worrying about though.

[Devlin, 2016-03-15 00:07:04]

https://codereview.chromium.org/1799223002/diff/20001/chrome/browser/extensio...
File
chrome/browser/extensions/api/extension_action/browser_action_interactive_test.cc
(right):

https://codereview.chromium.org/1799223002/diff/20001/chrome/browser/extensio...
chrome/browser/extensions/api/extension_action/browser_action_interactive_test.cc:301:

On 2016/03/14 23:11:24, Antony Sargent wrote:
> Is there any easy way to verify that the actual
> NOTIFICATION_EXTENSION_HOST_DESTROYED observed was for the one we caused to
> popup, and not some other random one that might have been created and
destroyed
> for an unrelated reason? (Maybe looking at the actual source passed to the
> observer?) If this is tricky it's probably not worth worrying about though. 

Not an easy one.  The source is a browser context and the details is an
ExtensionHost*.  The problem is that the ExtensionHost*, being closed, is
probably invalid by the time we're done waiting (and since there's only one
profile set up here, checking the browser context seems unnecessary).

In a perfect world, we'd have better test utils for this, but I don't think
anyone's had the time to do it. :(

[Devlin, 2016-03-15 00:08:09]

> If this is tricky it's probably not worth worrying about though.
Taking this escape hatch for now. :)  If we do get around to updating this to be
more specific, there are a lot of tests we can do in one fell swoop.

[Devlin, 2016-03-15 00:08:13]

The CQ bit was checked by rdevlin.cronin@chromium.org

[commit-bot: I haz the power, 2016-03-15 00:08:36]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1799223002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1799223002/20001

[commit-bot: I haz the power, 2016-03-15 00:13:42]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-03-15 00:15:40]

Description was changed from

==========
[Extensions] Fix BrowserActionInteractiveTest.TabSwitchClosesPopup

BUG=594417
==========

to

==========
[Extensions] Fix BrowserActionInteractiveTest.TabSwitchClosesPopup

BUG=594417

Committed: https://crrev.com/3dbedd030a19e84b9f5cc366daea1ea20556d5c0
Cr-Commit-Position: refs/heads/master@{#381125}
==========

[commit-bot: I haz the power, 2016-03-15 00:15:42]

Patchset 2 (id:??) landed as
https://crrev.com/3dbedd030a19e84b9f5cc366daea1ea20556d5c0
Cr-Commit-Position: refs/heads/master@{#381125}