content/browser/web_contents/web_contents_impl.cc - Issue 1799163002: Remove swapped out state from RenderFrameHost.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/web_contents/web_contents_impl.cc

Issue 1799163002: Remove swapped out state from RenderFrameHost. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixing failing layout test and adding an explicit test. Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/web_contents/web_contents_impl.cc

diff --git a/content/browser/web_contents/web_contents_impl.cc b/content/browser/web_contents/web_contents_impl.cc

index 4c9db9e5f9cb99eefdd32a65b9caa297a26e96b9..83c786214b17de7c482a0791dad7d6e13dc4957a 100644

--- a/content/browser/web_contents/web_contents_impl.cc

+++ b/content/browser/web_contents/web_contents_impl.cc

@@ -3846,7 +3846,6 @@ void WebContentsImpl::RunJavaScriptMessage(

// showing an interstitial as it's shown over the previous page and we don't

// want the hidden page's dialogs to interfere with the interstitial.

bool suppress_this_message =

- static_cast<RenderFrameHostImpl*>(render_frame_host)->is_swapped_out() ||

ShowingInterstitialPage() || !delegate_ ||

delegate_->ShouldSuppressDialogs(this) ||

!delegate_->GetJavaScriptDialogManager(this);