Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(878)

Unified Diff: content/browser/frame_host/render_frame_host_impl.h

Issue 1799163002: Remove swapped out state from RenderFrameHost. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixing failing layout test and adding an explicit test. Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/frame_host/render_frame_host_impl.h
diff --git a/content/browser/frame_host/render_frame_host_impl.h b/content/browser/frame_host/render_frame_host_impl.h
index 885258c81657b8c1577eacaaade793d9b579287a..46e56011b162b676d7da256f910ac082bfe89491 100644
--- a/content/browser/frame_host/render_frame_host_impl.h
+++ b/content/browser/frame_host/render_frame_host_impl.h
@@ -110,13 +110,8 @@ class CONTENT_EXPORT RenderFrameHostImpl : public RenderFrameHost,
STATE_DEFAULT = 0,
// The RFH has not received the SwapOutACK yet, but the new page has
// committed in a different RFH. Upon reception of the SwapOutACK, the RFH
- // will either enter STATE_SWAPPED_OUT (if it is a main frame and there are
- // other active frames in its SiteInstance) or it will be deleted.
+ // will be deleted.
STATE_PENDING_SWAP_OUT,
- // The RFH is swapped out and stored inside a RenderFrameProxyHost, being
- // used as a placeholder to allow cross-process communication. Only main
- // frames can enter this state.
- STATE_SWAPPED_OUT,
};
// Helper function to determine whether the RFH state should contribute to the
// number of active frames of a SiteInstance or not.
@@ -360,10 +355,6 @@ class CONTENT_EXPORT RenderFrameHostImpl : public RenderFrameHost,
// out.
void OnSwappedOut();
- // Whether this RenderFrameHost has been swapped out, such that the frame is
- // now rendered by a RenderFrameHost in a different process.
- bool is_swapped_out() const { return rfh_state_ == STATE_SWAPPED_OUT; }
-
// The current state of this RFH.
RenderFrameHostImplState rfh_state() const { return rfh_state_; }

Powered by Google App Engine
This is Rietveld 408576698