Remove swapped out state from RenderFrameHost.

content/browser/frame_host/navigator_impl.cc

Index: content/browser/frame_host/navigator_impl.cc
diff --git a/content/browser/frame_host/navigator_impl.cc b/content/browser/frame_host/navigator_impl.cc
index 5e33ea948ba39bddc3c137b822d662eb54cd7faf..4bc2f829177cf2dcb59fc3b821cbec2b74d61954 100644
--- a/content/browser/frame_host/navigator_impl.cc
+++ b/content/browser/frame_host/navigator_impl.cc
@@ -619,8 +619,7 @@ void NavigatorImpl::RequestOpenURL(RenderFrameHostImpl* render_frame_host,
   SiteInstance* current_site_instance = render_frame_host->frame_tree_node()
                                             ->current_frame_host()
                                             ->GetSiteInstance();
-  if (render_frame_host->is_swapped_out() &&
-      !render_frame_host->GetSiteInstance()->IsRelatedSiteInstance(
+  if (!render_frame_host->GetSiteInstance()->IsRelatedSiteInstance(

[Charlie Reis, 2016/03/14 20:12:57]

This looks wrong.  Before this block was unreachable because is_swapped_out()
was always false.  Now we can get to it.  Should we be removing the block
instead?

Alternatively, if this is a check that makes sense to have, we should update the
comment above it.  (I'm not sure off the top of my head if we do this
BrowsingInstance check sufficiently elsewhere.)

[nasko, 2016/03/14 21:32:30]

Ah, good point. We don't need the check overall, as if a RenderFrameHost is
getting this message, it must be alive or about to be deleted. If it is in the
process of swapping out, I think we still need to allow the call to go through
to keep it equivalent. 

           current_site_instance)) {
     return;
   }