Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(321)

Side by Side Diff: content/browser/renderer_host/render_view_host_impl.h

Issue 1799163002: Remove swapped out state from RenderFrameHost. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixing failing layout test and adding an explicit test. Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_BROWSER_RENDERER_HOST_RENDER_VIEW_HOST_IMPL_H_ 5 #ifndef CONTENT_BROWSER_RENDERER_HOST_RENDER_VIEW_HOST_IMPL_H_
6 #define CONTENT_BROWSER_RENDERER_HOST_RENDER_VIEW_HOST_IMPL_H_ 6 #define CONTENT_BROWSER_RENDERER_HOST_RENDER_VIEW_HOST_IMPL_H_
7 7
8 #include <stddef.h> 8 #include <stddef.h>
9 #include <stdint.h> 9 #include <stdint.h>
10 10
(...skipping 314 matching lines...) Expand 10 before | Expand all | Expand 10 after
325 private: 325 private:
326 // TODO(nasko): Temporarily friend RenderFrameHostImpl, so we don't duplicate 326 // TODO(nasko): Temporarily friend RenderFrameHostImpl, so we don't duplicate
327 // utility functions and state needed in both classes, while we move frame 327 // utility functions and state needed in both classes, while we move frame
328 // specific code away from this class. 328 // specific code away from this class.
329 friend class RenderFrameHostImpl; 329 friend class RenderFrameHostImpl;
330 friend class TestRenderViewHost; 330 friend class TestRenderViewHost;
331 FRIEND_TEST_ALL_PREFIXES(RenderViewHostTest, BasicRenderFrameHost); 331 FRIEND_TEST_ALL_PREFIXES(RenderViewHostTest, BasicRenderFrameHost);
332 FRIEND_TEST_ALL_PREFIXES(RenderViewHostTest, RoutingIdSane); 332 FRIEND_TEST_ALL_PREFIXES(RenderViewHostTest, RoutingIdSane);
333 FRIEND_TEST_ALL_PREFIXES(RenderFrameHostManagerTest, 333 FRIEND_TEST_ALL_PREFIXES(RenderFrameHostManagerTest,
334 CleanUpSwappedOutRVHOnProcessCrash); 334 CleanUpSwappedOutRVHOnProcessCrash);
335 FRIEND_TEST_ALL_PREFIXES(SitePerProcessBrowserTest,
336 NavigateMainFrameToChildSite);
337
335 // Send RenderViewReady to observers once the process is launched, but not 338 // Send RenderViewReady to observers once the process is launched, but not
336 // re-entrantly. 339 // re-entrantly.
337 void PostRenderViewReady(); 340 void PostRenderViewReady();
338 void RenderViewReady(); 341 void RenderViewReady();
339 342
340 // TODO(creis): Move to a private namespace on RenderFrameHostImpl. 343 // TODO(creis): Move to a private namespace on RenderFrameHostImpl.
341 // Delay to wait on closing the WebContents for a beforeunload/unload handler 344 // Delay to wait on closing the WebContents for a beforeunload/unload handler
342 // to fire. 345 // to fire.
343 static const int64_t kUnloadTimeoutMS; 346 static const int64_t kUnloadTimeoutMS;
344 347
(...skipping 84 matching lines...) Expand 10 before | Expand all | Expand 10 after
429 bool render_view_ready_on_process_launch_; 432 bool render_view_ready_on_process_launch_;
430 433
431 base::WeakPtrFactory<RenderViewHostImpl> weak_factory_; 434 base::WeakPtrFactory<RenderViewHostImpl> weak_factory_;
432 435
433 DISALLOW_COPY_AND_ASSIGN(RenderViewHostImpl); 436 DISALLOW_COPY_AND_ASSIGN(RenderViewHostImpl);
434 }; 437 };
435 438
436 } // namespace content 439 } // namespace content
437 440
438 #endif // CONTENT_BROWSER_RENDERER_HOST_RENDER_VIEW_HOST_IMPL_H_ 441 #endif // CONTENT_BROWSER_RENDERER_HOST_RENDER_VIEW_HOST_IMPL_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698