Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(508)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1799113003: Pass the 'extra' parameter for X64OperandConverter::ToOperand (Closed)

Created:
4 years, 9 months ago by Mircea Trofin
Modified:
4 years, 9 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Pass the 'extra' parameter for X64OperandConverter::ToOperand BUG= Committed: https://crrev.com/3941f3474d4ff77a8df815320576e92294b1cbbe Cr-Commit-Position: refs/heads/master@{#34750}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/compiler/x64/code-generator-x64.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (3 generated)
Jarin
I am sorry for the silly mistake; thanks for investigation! lgtm.
4 years, 9 months ago (2016-03-14 15:39:26 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1799113003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1799113003/1
4 years, 9 months ago (2016-03-14 15:43:27 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-14 16:13:50 UTC) #5
commit-bot: I haz the power
4 years, 9 months ago (2016-03-14 16:15:06 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/3941f3474d4ff77a8df815320576e92294b1cbbe
Cr-Commit-Position: refs/heads/master@{#34750}

Powered by Google App Engine
This is Rietveld 408576698