🚄 test_runner.py: Auto-detect output dir when running on bots

test_runner.py: Auto-detect output dir when running on bots

BUG=594105, 593973
Committed: https://crrev.com/c91b537eb16a73f49e61b08e8d24cfbc4649ed75
Cr-Commit-Position: refs/heads/master@{#381032}

[agrieve, 2016-03-14 17:33:59]

Description was changed from

==========
test_runner.py: Auto-detect output dir when running on bots

BUG=594105,593973
==========

to

==========
test_runner.py: Auto-detect output dir when running on bots

BUG=594105,593973
==========

[agrieve, 2016-03-14 17:33:59]

agrieve@chromium.org changed reviewers:
+ jbudorick@chromium.org

[agrieve, 2016-03-14 17:35:55]

On 2016/03/14 17:33:59, agrieve wrote:
> mailto:agrieve@chromium.org changed reviewers:
> + mailto:jbudorick@chromium.org

Couldn't find any place in the perf recipes where the recipe even knows where
the output directory is! I think the perf scripts are just hard-coded to look in
out/Release.

[jbudorick, 2016-03-14 17:41:35]

I really really really do not like autodetecting paths.

https://codereview.chromium.org/1799073004/diff/1/build/android/pylib/constan...
File build/android/pylib/constants/__init__.py (right):

https://codereview.chromium.org/1799073004/diff/1/build/android/pylib/constan...
build/android/pylib/constants/__init__.py:266: dirs =
glob.glob(os.path.join(DIR_SOURCE_ROOT, 'out', '*', 'build.ninja'))
I don't think this will work with gyp bots, which will have both
out/Debug/build.ninja and out/Release/build.ninja.

[agrieve, 2016-03-14 17:48:04]

On 2016/03/14 17:41:35, jbudorick wrote:
> I really really really do not like autodetecting paths.
Me too :(

> 
>
https://codereview.chromium.org/1799073004/diff/1/build/android/pylib/constan...
> File build/android/pylib/constants/__init__.py (right):
> 
>
https://codereview.chromium.org/1799073004/diff/1/build/android/pylib/constan...
> build/android/pylib/constants/__init__.py:266: dirs =
> glob.glob(os.path.join(DIR_SOURCE_ROOT, 'out', '*', 'build.ninja'))
> I don't think this will work with gyp bots, which will have both
> out/Debug/build.ninja and out/Release/build.ninja.

The extraction step on the broken bots list only one subdirectory. If this does
end up fixing the currently-broken bots, then I don't think we need to
accommodate gyp.

[agrieve, 2016-03-14 17:48:42]

On 2016/03/14 17:48:04, agrieve wrote:
> On 2016/03/14 17:41:35, jbudorick wrote:
> > I really really really do not like autodetecting paths.
> Me too :(
> 
> > 
> >
>
https://codereview.chromium.org/1799073004/diff/1/build/android/pylib/constan...
> > File build/android/pylib/constants/__init__.py (right):
> > 
> >
>
https://codereview.chromium.org/1799073004/diff/1/build/android/pylib/constan...
> > build/android/pylib/constants/__init__.py:266: dirs =
> > glob.glob(os.path.join(DIR_SOURCE_ROOT, 'out', '*', 'build.ninja'))
> > I don't think this will work with gyp bots, which will have both
> > out/Debug/build.ninja and out/Release/build.ninja.
> 
> The extraction step on the broken bots list only one subdirectory. If this
does
> end up fixing the currently-broken bots, then I don't think we need to
> accommodate gyp.

Although - if you can figure out where in the recipes the output directory is
actually known, I can try to plumb it through.

[jbudorick, 2016-03-14 17:49:41]

lgtm in the interest of fixing the bots.

I'll try look into the recipe plumbing parts when I get a chance -- maybe some
time later this week or next week.

[agrieve, 2016-03-14 17:50:43]

The CQ bit was checked by agrieve@chromium.org

[commit-bot: I haz the power, 2016-03-14 17:51:06]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1799073004/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1799073004/1

[commit-bot: I haz the power, 2016-03-14 19:05:07]

Description was changed from

==========
test_runner.py: Auto-detect output dir when running on bots

BUG=594105,593973
==========

to

==========
test_runner.py: Auto-detect output dir when running on bots

BUG=594105,593973
==========

[commit-bot: I haz the power, 2016-03-14 19:05:08]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-03-14 19:06:50]

Description was changed from

==========
test_runner.py: Auto-detect output dir when running on bots

BUG=594105,593973
==========

to

==========
test_runner.py: Auto-detect output dir when running on bots

BUG=594105,593973

Committed: https://crrev.com/c91b537eb16a73f49e61b08e8d24cfbc4649ed75
Cr-Commit-Position: refs/heads/master@{#381032}
==========

[commit-bot: I haz the power, 2016-03-14 19:06:51]

Patchset 1 (id:??) landed as
https://crrev.com/c91b537eb16a73f49e61b08e8d24cfbc4649ed75
Cr-Commit-Position: refs/heads/master@{#381032}