chrome/chrome_installer.gypi - Issue 179903004: Always embed manifests, even in component builds!

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/chrome_installer.gypi

Issue 179903004: Always embed manifests, even in component builds! (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: re-add explicit 'EmbedManifest': 'false'; needed? Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/chrome_installer.gypi

diff --git a/chrome/chrome_installer.gypi b/chrome/chrome_installer.gypi

index 658db4b51ececbb442123f50d705f00cb8a1a57c..e5b9af9c8f55352dbf50b97085c980e7ed5373ab 100644

--- a/chrome/chrome_installer.gypi

+++ b/chrome/chrome_installer.gypi

@@ -359,11 +359,6 @@

'conditions': [

- ['component == "shared_library"', {

- 'variables': {

- 'win_use_external_manifest': 1,

- },

- }],

# TODO(mark): <(branding_dir) should be defined by the

# global condition block at the bottom of the file, but

# this doesn't work due to the following issue: