Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(267)

Issue 1799023003: [turbofan] Use the type from the typer instead of computing new type in representation inference. (Closed)

Created:
4 years, 9 months ago by Jarin
Modified:
4 years, 9 months ago
CC:
v8-reviews_googlegroups.com, Benedikt Meurer
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Use the type from the typer instead of computing new type in representation inference. Committed: https://crrev.com/811137ffe58b3a136dcf2eac3321c225883b455e Cr-Commit-Position: refs/heads/master@{#34917}

Patch Set 1 #

Patch Set 2 : Fix uninitialized field #

Unified diffs Side-by-side diffs Delta from patch set Stats (+150 lines, -270 lines) Patch
M src/compiler/simplified-lowering.cc View 1 37 chunks +140 lines, -263 lines 0 comments Download
M test/cctest/compiler/test-simplified-lowering.cc View 2 chunks +10 lines, -7 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
Jarin
Could you take a look, please? Yes, it is a bit scary as the representation ...
4 years, 9 months ago (2016-03-14 15:37:40 UTC) #3
Benedikt Meurer
LGTM.
4 years, 9 months ago (2016-03-21 05:50:50 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1799023003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1799023003/20001
4 years, 9 months ago (2016-03-21 06:06:41 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 9 months ago (2016-03-21 06:28:45 UTC) #8
commit-bot: I haz the power
4 years, 9 months ago (2016-03-21 06:29:52 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/811137ffe58b3a136dcf2eac3321c225883b455e
Cr-Commit-Position: refs/heads/master@{#34917}

Powered by Google App Engine
This is Rietveld 408576698