Issue 1798993003: Added tests; improved test output; code clean-up

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1798993003: Added tests; improved test output; code clean-up (Closed)

Created:
4 years, 9 months ago by Brian Wilkerson

Modified:
4 years, 9 months ago

Reviewers:
scheglov

CC:
reviews_dartlang.org

Base URL:
https://github.com/dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Created: 4 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+73 lines, -2 lines)			Patch
M	pkg/analyzer/lib/src/generated/constant.dart	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	pkg/analyzer/lib/src/generated/error.dart	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	pkg/analyzer/test/src/task/dart_test.dart	View	2 chunks	+68 lines, -0 lines	0 comments	Download

Total messages: 5 (2 generated)

Brian Wilkerson

The tests were added in a failed attempt to reproduce issue 25971.

4 years, 9 months ago (2016-03-14 17:31:12 UTC) #2

Brian Wilkerson

4 years, 9 months ago (2016-03-14 17:34:15 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
04386592a78f2f2deaea2e7f4a34f903eacf7539 (presubmit successful).