[wasm] Int64Lowering: changing to DFS.

[wasm] Int64Lowering: changing to DFS.

R=titzer@chromium.org

Committed: https://crrev.com/c4c34eba30be41ad2ef741d2bc69a26ce7fab83c
Cr-Commit-Position: refs/heads/master@{#34767}

[titzer, 2016-03-14 14:14:14]

https://codereview.chromium.org/1798993002/diff/1/src/compiler/int64-lowering.cc
File src/compiler/int64-lowering.cc (right):

https://codereview.chromium.org/1798993002/diff/1/src/compiler/int64-lowering...
src/compiler/int64-lowering.cc:43: stack_.pop();
You can move the pop into the true branch and drop the re-pushing in the false
branch.

https://codereview.chromium.org/1798993002/diff/1/src/compiler/int64-lowering...
src/compiler/int64-lowering.cc:50: // Push all children onto the stack.
Update comment.

https://codereview.chromium.org/1798993002/diff/1/src/compiler/int64-lowering...
src/compiler/int64-lowering.cc:51: Node* input =
top.node->InputAt(top.input_index);
It's ok to through the ++ inside here, too.

[ahaas, 2016-03-14 14:25:18]

https://codereview.chromium.org/1798993002/diff/1/src/compiler/int64-lowering.cc
File src/compiler/int64-lowering.cc (right):

https://codereview.chromium.org/1798993002/diff/1/src/compiler/int64-lowering...
src/compiler/int64-lowering.cc:43: stack_.pop();
On 2016/03/14 at 14:14:13, titzer wrote:
> You can move the pop into the true branch and drop the re-pushing in the false
branch.

Done.

https://codereview.chromium.org/1798993002/diff/1/src/compiler/int64-lowering...
src/compiler/int64-lowering.cc:50: // Push all children onto the stack.
On 2016/03/14 at 14:14:13, titzer wrote:
> Update comment.

Done.

https://codereview.chromium.org/1798993002/diff/1/src/compiler/int64-lowering...
src/compiler/int64-lowering.cc:51: Node* input =
top.node->InputAt(top.input_index);
On 2016/03/14 at 14:14:13, titzer wrote:
> It's ok to through the ++ inside here, too.

Done.

[titzer, 2016-03-14 14:28:17]

lgtm with nit

https://codereview.chromium.org/1798993002/diff/20001/src/compiler/int64-lowe...
File src/compiler/int64-lowering.cc (right):

https://codereview.chromium.org/1798993002/diff/20001/src/compiler/int64-lowe...
src/compiler/int64-lowering.cc:45: // if (state_.Get(top) ==
State::kInputsPushed) {
Why is this line of code commented out?

[ahaas, 2016-03-14 14:41:50]

https://codereview.chromium.org/1798993002/diff/20001/src/compiler/int64-lowe...
File src/compiler/int64-lowering.cc (right):

https://codereview.chromium.org/1798993002/diff/20001/src/compiler/int64-lowe...
src/compiler/int64-lowering.cc:45: // if (state_.Get(top) ==
State::kInputsPushed) {
On 2016/03/14 at 14:28:17, titzer wrote:
> Why is this line of code commented out?

Deleted.

[ahaas, 2016-03-15 06:01:51]

The CQ bit was checked by ahaas@chromium.org

[ahaas, 2016-03-15 06:01:51]

The patchset sent to the CQ was uploaded after l-g-t-m from titzer@chromium.org
Link to the patchset: https://codereview.chromium.org/1798993002/#ps60001
(title: "Rebase + Turn on tests which require DFS.")

[commit-bot: I haz the power, 2016-03-15 06:01:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-15 06:01:57]

This CL has an open dependency (Issue 1804913002 Patch 1). Please resolve the
dependency and try again.

[ahaas, 2016-03-15 06:05:57]

The CQ bit was checked by ahaas@chromium.org

[ahaas, 2016-03-15 06:05:58]

The patchset sent to the CQ was uploaded after l-g-t-m from titzer@chromium.org
Link to the patchset: https://codereview.chromium.org/1798993002/#ps80001
(title: "Removed wrong dependency")

[commit-bot: I haz the power, 2016-03-15 06:06:08]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1798993002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1798993002/80001

[commit-bot: I haz the power, 2016-03-15 06:26:32]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-03-15 06:27:07]

Description was changed from

==========
[wasm] Int64Lowering: changing to DFS.

R=titzer@chromium.org
==========

to

==========
[wasm] Int64Lowering: changing to DFS.

R=titzer@chromium.org

Committed: https://crrev.com/c4c34eba30be41ad2ef741d2bc69a26ce7fab83c
Cr-Commit-Position: refs/heads/master@{#34767}
==========

[commit-bot: I haz the power, 2016-03-15 06:27:08]

Patchset 5 (id:??) landed as
https://crrev.com/c4c34eba30be41ad2ef741d2bc69a26ce7fab83c
Cr-Commit-Position: refs/heads/master@{#34767}