Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Issue 1798963003: Remove fixed tests from TestExpectation file (Closed)

Created:
4 years, 9 months ago by Navid Zolghadr
Modified:
4 years, 9 months ago
Reviewers:
mustaq, Rick Byers
CC:
chromium-reviews, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove fixed tests from TestExpectation file These tests were failing because of a state that was not reset in the content_shell and it was being carried over from other tests and resulting these test to fail. The blocking bug is now fixed and that state is being reset so these tests are always passing now. Marking the rest of the tests for another bug as they seem to have another reason for failing. BUG=591821, 594672 Committed: https://crrev.com/228ea6faf71a8e33938caf6d2c04f80ae786dbf2 Cr-Commit-Position: refs/heads/master@{#381211}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -40 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 2 1 chunk +10 lines, -40 lines 0 comments Download

Messages

Total messages: 14 (8 generated)
Navid Zolghadr
4 years, 9 months ago (2016-03-14 15:28:29 UTC) #3
mustaq
On 2016/03/14 15:28:29, Navid Zolghadr wrote: Thanks Navid for the investigation that led to this ...
4 years, 9 months ago (2016-03-14 15:45:34 UTC) #4
Rick Byers
On 2016/03/14 15:45:34, mustaq wrote: > On 2016/03/14 15:28:29, Navid Zolghadr wrote: > > Thanks ...
4 years, 9 months ago (2016-03-14 19:13:07 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1798963003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1798963003/40001
4 years, 9 months ago (2016-03-15 12:10:26 UTC) #10
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 9 months ago (2016-03-15 12:15:05 UTC) #12
commit-bot: I haz the power
4 years, 9 months ago (2016-03-15 12:18:25 UTC) #14
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/228ea6faf71a8e33938caf6d2c04f80ae786dbf2
Cr-Commit-Position: refs/heads/master@{#381211}

Powered by Google App Engine
This is Rietveld 408576698