Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(190)

Issue 1798923002: [interpreter] Use bytecode-array-iterator in BytecodeArray::Print(). (Closed)

Created:
4 years, 9 months ago by oth
Modified:
4 years, 9 months ago
Reviewers:
rmcilroy
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[interpreter] Use bytecode-array-iterator in BytecodeArray::Print(). BUG=v8:4280 LOG=N Committed: https://crrev.com/7a63e0be771d3b0d2bd7cde8e5a8f1951addb213 Cr-Commit-Position: refs/heads/master@{#34752}

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -33 lines) Patch
M src/objects.cc View 1 2 chunks +12 lines, -33 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
oth
Per comment from scalable operands review. PTAL, thanks.
4 years, 9 months ago (2016-03-14 11:07:06 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1798923002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1798923002/1
4 years, 9 months ago (2016-03-14 14:37:07 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 9 months ago (2016-03-14 15:30:10 UTC) #6
rmcilroy
Awesome, looks great, thanks! LGTM.
4 years, 9 months ago (2016-03-14 15:50:12 UTC) #7
oth
On 2016/03/14 15:50:12, rmcilroy wrote: > Awesome, looks great, thanks! > > LGTM. Steady on, ...
4 years, 9 months ago (2016-03-14 16:15:55 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1798923002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1798923002/20001
4 years, 9 months ago (2016-03-14 16:16:27 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 9 months ago (2016-03-14 17:07:05 UTC) #12
commit-bot: I haz the power
4 years, 9 months ago (2016-03-14 17:07:46 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/7a63e0be771d3b0d2bd7cde8e5a8f1951addb213
Cr-Commit-Position: refs/heads/master@{#34752}

Powered by Google App Engine
This is Rietveld 408576698