Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Issue 1798913002: WTF HashSet: Implement move semantics for values. (Closed)

Created:
4 years, 9 months ago by Yuta Kitamura
Modified:
4 years, 9 months ago
Reviewers:
*haraken, *tzik, Mikhail
CC:
chromium-reviews, sof, eae+blinkwatch, blink-reviews-dom_chromium.org, dglazkov+blink, blink-reviews, blink-reviews-wtf_chromium.org, Mikhail, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

WTF HashSet: Implement move semantics for values. This is a follow-up of the following patch where move semantics for HashMap values were implemented: https://codereview.chromium.org/1764973002/ This patch basically does the same thing. At this time, we don't have to use the "Extra" part of hash table translators, since HashSet saves only the keys. The overload of add<Translator>(...) is renamed to addWithTranslator, because (1) the function signatures of normal add() and translator add() are pretty confusing, and (2) add<Translator>() version is rarely used. I left addWithTranslator without move semantics, as I was not sure if we should do that. StringHash needs some modification to resolve overload ambiguities arose from string literals. BUG=567139, 582349 Committed: https://crrev.com/01875a5b228e8d84bc92db4b634df054efcf9216 Cr-Commit-Position: refs/heads/master@{#381403}

Patch Set 1 #

Patch Set 2 : Rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+150 lines, -18 lines) Patch
M third_party/WebKit/Source/core/dom/QualifiedName.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/web/AssociatedURLLoader.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/wtf/HashSet.h View 4 chunks +12 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/wtf/HashSetTest.cpp View 1 1 chunk +123 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/wtf/HashTable.h View 1 3 chunks +6 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/wtf/text/AtomicString.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/wtf/text/StringHash.h View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 26 (14 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1798913002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1798913002/1
4 years, 9 months ago (2016-03-14 10:47:31 UTC) #2
Yuta Kitamura
PTAL
4 years, 9 months ago (2016-03-14 10:47:58 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 9 months ago (2016-03-14 12:01:40 UTC) #8
tzik
lgtm
4 years, 9 months ago (2016-03-15 07:25:06 UTC) #10
haraken
LGTM
4 years, 9 months ago (2016-03-15 12:34:59 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1798913002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1798913002/1
4 years, 9 months ago (2016-03-16 00:32:32 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator_gn on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator_gn/builds/4924) ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, ...
4 years, 9 months ago (2016-03-16 00:34:38 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1798913002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1798913002/20001
4 years, 9 months ago (2016-03-16 01:26:49 UTC) #18
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/157423)
4 years, 9 months ago (2016-03-16 01:36:12 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1798913002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1798913002/20001
4 years, 9 months ago (2016-03-16 04:18:33 UTC) #22
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 9 months ago (2016-03-16 05:30:22 UTC) #24
commit-bot: I haz the power
4 years, 9 months ago (2016-03-16 05:32:20 UTC) #26
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/01875a5b228e8d84bc92db4b634df054efcf9216
Cr-Commit-Position: refs/heads/master@{#381403}

Powered by Google App Engine
This is Rietveld 408576698