Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Side by Side Diff: third_party/WebKit/Source/core/css/parser/LegacyCSSPropertyParser.cpp

Issue 1798863005: Move some grid-column/grid-row related longhands into CSSPropertyParser (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Standalone change Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2003 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 2003 Lars Knoll (knoll@kde.org)
3 * Copyright (C) 2005 Allan Sandfeld Jensen (kde@carewolf.com) 3 * Copyright (C) 2005 Allan Sandfeld Jensen (kde@carewolf.com)
4 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011, 2012 Apple Inc. All rights reserved. 4 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011, 2012 Apple Inc. All rights reserved.
5 * Copyright (C) 2007 Nicholas Shanks <webkit@nickshanks.com> 5 * Copyright (C) 2007 Nicholas Shanks <webkit@nickshanks.com>
6 * Copyright (C) 2008 Eric Seidel <eric@webkit.org> 6 * Copyright (C) 2008 Eric Seidel <eric@webkit.org>
7 * Copyright (C) 2009 Torch Mobile Inc. All rights reserved. (http://www.torchmo bile.com/) 7 * Copyright (C) 2009 Torch Mobile Inc. All rights reserved. (http://www.torchmo bile.com/)
8 * Copyright (C) 2012 Adobe Systems Incorporated. All rights reserved. 8 * Copyright (C) 2012 Adobe Systems Incorporated. All rights reserved.
9 * Copyright (C) 2012 Intel Corporation. All rights reserved. 9 * Copyright (C) 2012 Intel Corporation. All rights reserved.
10 * 10 *
(...skipping 258 matching lines...) Expand 10 before | Expand all | Expand 10 after
269 ASSERT(RuntimeEnabledFeatures::cssGridLayoutEnabled()); 269 ASSERT(RuntimeEnabledFeatures::cssGridLayoutEnabled());
270 parsedValue = parseGridTrackSize(*m_valueList); 270 parsedValue = parseGridTrackSize(*m_valueList);
271 break; 271 break;
272 272
273 case CSSPropertyGridTemplateColumns: 273 case CSSPropertyGridTemplateColumns:
274 case CSSPropertyGridTemplateRows: 274 case CSSPropertyGridTemplateRows:
275 ASSERT(RuntimeEnabledFeatures::cssGridLayoutEnabled()); 275 ASSERT(RuntimeEnabledFeatures::cssGridLayoutEnabled());
276 parsedValue = parseGridTrackList(); 276 parsedValue = parseGridTrackList();
277 break; 277 break;
278 278
279 case CSSPropertyGridColumnEnd:
280 case CSSPropertyGridColumnStart:
281 case CSSPropertyGridRowEnd:
282 case CSSPropertyGridRowStart:
283 ASSERT(RuntimeEnabledFeatures::cssGridLayoutEnabled());
284 parsedValue = parseGridPosition();
285 break;
286
287 case CSSPropertyGridTemplateAreas: 279 case CSSPropertyGridTemplateAreas:
288 ASSERT(RuntimeEnabledFeatures::cssGridLayoutEnabled()); 280 ASSERT(RuntimeEnabledFeatures::cssGridLayoutEnabled());
289 parsedValue = parseGridTemplateAreas(); 281 parsedValue = parseGridTemplateAreas();
290 break; 282 break;
291 283
292 // Everything else is handled in CSSPropertyParser.cpp 284 // Everything else is handled in CSSPropertyParser.cpp
293 default: 285 default:
294 return nullptr; 286 return nullptr;
295 } 287 }
296 288
(...skipping 807 matching lines...) Expand 10 before | Expand all | Expand 10 after
1104 ASSERT(!m_parsedCalculation); 1096 ASSERT(!m_parsedCalculation);
1105 m_parsedCalculation = CSSCalcValue::create(args, range); 1097 m_parsedCalculation = CSSCalcValue::create(args, range);
1106 1098
1107 if (!m_parsedCalculation) 1099 if (!m_parsedCalculation)
1108 return false; 1100 return false;
1109 1101
1110 return true; 1102 return true;
1111 } 1103 }
1112 1104
1113 } // namespace blink 1105 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698