Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(457)

Issue 1798863003: Revert of Allow Math.random to be called when creating a custom startup snapshot. (Closed)

Created:
4 years, 9 months ago by Yang
Modified:
4 years, 9 months ago
Reviewers:
Jakob Kummerow
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@testserialize
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Allow Math.random to be called when creating a custom startup snapshot. (patchset #2 id:20001 of https://codereview.chromium.org/1780173002/ ) Reason for revert: Regresses performance on base64 benchmark. Original issue's description: > Allow Math.random to be called when creating a custom startup snapshot. > > R=jkummerow@chromium.org > BUG=v8:4810 > LOG=N > > Committed: https://crrev.com/6a7ec6a3bf779cdd41c66a768fd7a37195ed7b7f > Cr-Commit-Position: refs/heads/master@{#34705} TBR=jkummerow@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=v8:4810, chromium:594484 LOG=N Committed: https://crrev.com/b7be51cd33bc81d768dbf5632ba0c68843448e37 Cr-Commit-Position: refs/heads/master@{#34739}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -40 lines) Patch
M src/js/math.js View 3 chunks +10 lines, -14 lines 0 comments Download
M src/runtime/runtime-maths.cc View 1 chunk +2 lines, -12 lines 0 comments Download
M test/cctest/test-serialize.cc View 2 chunks +2 lines, -14 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
Yang
Created Revert of Allow Math.random to be called when creating a custom startup snapshot.
4 years, 9 months ago (2016-03-14 10:05:07 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1798863003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1798863003/1
4 years, 9 months ago (2016-03-14 10:05:09 UTC) #2
Jakob Kummerow
lgtm
4 years, 9 months ago (2016-03-14 10:06:06 UTC) #3
commit-bot: I haz the power
Try jobs failed on following builders: v8_presubmit on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/12301)
4 years, 9 months ago (2016-03-14 10:08:20 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1798863003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1798863003/1
4 years, 9 months ago (2016-03-14 10:14:01 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-14 10:26:22 UTC) #11
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/b7be51cd33bc81d768dbf5632ba0c68843448e37 Cr-Commit-Position: refs/heads/master@{#34739}
4 years, 9 months ago (2016-03-14 10:27:26 UTC) #13
Yang
4 years, 9 months ago (2016-03-16 13:22:53 UTC) #14
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1806713003/ by yangguo@chromium.org.

The reason for reverting is: This seems not to change performance..

Powered by Google App Engine
This is Rietveld 408576698