Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 1798733003: Add experimental accessibility features to Material Design settings (Closed)

Created:
4 years, 9 months ago by dmazzoni
Modified:
4 years, 9 months ago
CC:
chromium-reviews, extensions-reviews_chromium.org, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, arv+watch_chromium.org, chromium-apps-reviews_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@add_5_a11y_features
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add experimental accessibility features to Material Design settings BUG=314889, 593887, 593885 TBR=rockot@chromium.org Committed: https://crrev.com/5b7bb09612949e3334a7a79fa5673349398edcd2 Cr-Commit-Position: refs/heads/master@{#381407}

Patch Set 1 #

Patch Set 2 : Simplify #

Patch Set 3 : Rebase, get rid of unrelated changes #

Total comments: 4

Patch Set 4 : Add TODO for accessibility prefs #

Patch Set 5 : Add includes, fix whitespace #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -0 lines) Patch
M chrome/browser/extensions/api/settings_private/prefs_util.cc View 1 2 3 4 1 chunk +10 lines, -0 lines 0 comments Download
M chrome/browser/resources/settings/a11y_page/a11y_page.html View 1 2 3 4 1 chunk +17 lines, -0 lines 0 comments Download
M chrome/browser/resources/settings/a11y_page/a11y_page.js View 1 1 chunk +11 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc View 1 2 3 4 4 chunks +16 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 21 (10 generated)
dmazzoni
4 years, 9 months ago (2016-03-14 05:30:11 UTC) #2
Dan Beam
lgtm w/nits thanks for porting this! you rock! https://codereview.chromium.org/1798733003/diff/40001/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc File chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc (right): https://codereview.chromium.org/1798733003/diff/40001/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc#newcode8 chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc:8: #include ...
4 years, 9 months ago (2016-03-14 21:24:12 UTC) #3
dmazzoni
https://codereview.chromium.org/1798733003/diff/40001/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc File chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc (right): https://codereview.chromium.org/1798733003/diff/40001/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc#newcode103 chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc:103: IDS_OPTIONS_SETTINGS_ACCESSIBILITY_SWITCH_ACCESS_DESCRIPTION }, On 2016/03/14 21:24:12, Dan Beam wrote: > ...
4 years, 9 months ago (2016-03-15 21:27:04 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1798733003/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1798733003/80001
4 years, 9 months ago (2016-03-16 04:49:19 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/157472)
4 years, 9 months ago (2016-03-16 05:00:45 UTC) #9
dmazzoni
+rockot for chrome/browser/extensions
4 years, 9 months ago (2016-03-16 05:18:39 UTC) #11
dmazzoni
(TBR=rockot because it's trivial and follows the previous approved change)
4 years, 9 months ago (2016-03-16 05:19:30 UTC) #13
Ken Rockot(use gerrit already)
rs lgtm
4 years, 9 months ago (2016-03-16 05:19:42 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1798733003/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1798733003/80001
4 years, 9 months ago (2016-03-16 05:20:08 UTC) #17
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years, 9 months ago (2016-03-16 05:47:02 UTC) #19
commit-bot: I haz the power
4 years, 9 months ago (2016-03-16 05:48:01 UTC) #21
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/5b7bb09612949e3334a7a79fa5673349398edcd2
Cr-Commit-Position: refs/heads/master@{#381407}

Powered by Google App Engine
This is Rietveld 408576698