Issue 179873020: [import] The first <link rel=import> should win in the cascading order computation.

Issue 179873020: [import] The first <link rel=import> should win in the cascading order computation. (Closed)

Created:
6 years, 9 months ago by Hajime Morrita

Modified:
6 years, 9 months ago

Reviewers:
esprehn, dglazkov

CC:
blink-reviews, sof, eae+blinkwatch, dglazkov+blink, adamk+blink_chromium.org, Inactive, rwlbuis

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

[import] The first <link rel=import> should win in the cascading order computation. Before this change, stylesheets in imports are ordered based on <link>s that "own" these imports. The ownership however is an implementation detail and shouldn't be observable. With this change, it takes only the tree order of <link>s into account. The ownership no longer plays any role. BUG=346878 TEST=import-style-tree-order-dedup.html R=esprehn@chromium.org, dglazkov@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=168351

Patch Set 1 #

Patch Set 2 : Added a missing expectation file. #

Patch Set 3 : Updated to ToT #

Total comments: 1

Patch Set 4 : Landing #

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+89 lines, -14 lines)			Patch
A	LayoutTests/fast/html/imports/import-style-tree-order-dedup.html	View	1 2 3	1 chunk	+57 lines, -0 lines	0 comments	Download
A	LayoutTests/fast/html/imports/import-style-tree-order-dedup-expected.txt	View	1	1 chunk	+13 lines, -0 lines	0 comments	Download
A +	LayoutTests/fast/html/imports/resources/style-target-blue.html	View		1 chunk	+2 lines, -4 lines	0 comments	Download
M	Source/core/dom/DocumentStyleSheetCollection.cpp	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	Source/core/dom/DocumentStyleSheetCollector.h	View		2 chunks	+9 lines, -1 line	0 comments	Download
M	Source/core/dom/DocumentStyleSheetCollector.cpp	View		2 chunks	+4 lines, -3 lines	0 comments	Download
M	Source/core/dom/StyleSheetCandidate.cpp	View		1 chunk	+1 line, -6 lines	0 comments	Download

Messages

Total messages: 11 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

The CQ bit was unchecked by commit-bot@chromium.org

6 years, 9 months ago (2014-03-03 20:42:56 UTC) #4

commit-bot: I haz the power

No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...

6 years, 9 months ago (2014-03-03 20:42:56 UTC) #5

Hajime Morrita

Elliott, could you take a look? This fix is about the cascading order of imported ...

6 years, 9 months ago (2014-03-03 20:44:05 UTC) #6

esprehn

seems reasonable, lgtm https://codereview.chromium.org/179873020/diff/40001/LayoutTests/fast/html/imports/import-style-tree-order-dedup.html File LayoutTests/fast/html/imports/import-style-tree-order-dedup.html (right): https://codereview.chromium.org/179873020/diff/40001/LayoutTests/fast/html/imports/import-style-tree-order-dedup.html#newcode3 LayoutTests/fast/html/imports/import-style-tree-order-dedup.html:3: <body> I'd omit the <html> and ...

6 years, 9 months ago (2014-03-03 21:01:44 UTC) #7

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/morrita@chromium.org/179873020/60001

6 years, 9 months ago (2014-03-03 21:33:30 UTC) #9

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/morrita@chromium.org/179873020/60001

6 years, 9 months ago (2014-03-03 23:22:24 UTC) #10

Message was sent while issue was closed.

Change committed as 168351

Expand Messages | Collapse Messages