Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Unified Diff: tools/gn/gyp_binary_target_writer.cc

Issue 179873008: GN: Work on Mac module search path. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« build/config/mac/BUILD.gn ('K') | « build/config/mac/BUILD.gn ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gn/gyp_binary_target_writer.cc
diff --git a/tools/gn/gyp_binary_target_writer.cc b/tools/gn/gyp_binary_target_writer.cc
index d80616ebf01e3ffdfef946b60e36986109f6303d..c753fa3fb777179af37acf90307c675c3c278fc1 100644
--- a/tools/gn/gyp_binary_target_writer.cc
+++ b/tools/gn/gyp_binary_target_writer.cc
@@ -473,7 +473,7 @@ void GypBinaryTargetWriter::WriteMacFlags(const Target* target,
// When writing an iOS "target" (not host) target, we set VALID_ARCHS
// instead of ARCHS and always use this hardcoded value. This matches the
// GYP build.
- Indent(indent + kExtraIndent) << "'VALID_ARCHS': 'armv7 i386',\n";
+ Indent(indent + kExtraIndent) << "'VALID_ARCHS': ['armv7', 'i386'],\n";
// Tell XCode to target both iPhone and iPad. GN has no such concept.
Indent(indent + kExtraIndent) << "'TARGETED_DEVICE_FAMILY': '1,2',\n";
« build/config/mac/BUILD.gn ('K') | « build/config/mac/BUILD.gn ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698