Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 179873008: GN: Work on Mac module search path. (Closed)

Created:
6 years, 10 months ago by brettw
Modified:
6 years, 9 months ago
CC:
chromium-reviews, erikwright+watch_chromium.org
Visibility:
Public.

Description

GN: Work on Mac module search path. This hooks up the rpath for Mac executables. This fixes a bug in iOS GYP generation where the architectures were specified as a string instead of a list. Also fixes some base files that were out-of-sync from the GYP build. BUG=345021 TBR=thakis Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=253952

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -9 lines) Patch
M base/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M build/config/BUILDCONFIG.gn View 1 chunk +3 lines, -1 line 0 comments Download
M build/config/compiler/BUILD.gn View 1 chunk +1 line, -7 lines 0 comments Download
M build/config/mac/BUILD.gn View 1 chunk +13 lines, -0 lines 1 comment Download
M tools/gn/gyp_binary_target_writer.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
brettw
6 years, 10 months ago (2014-02-26 22:33:06 UTC) #1
brettw
Nico is on vacation -> Scott.
6 years, 9 months ago (2014-02-27 20:44:14 UTC) #2
scottmg
On 2014/02/27 20:44:14, brettw wrote: > Nico is on vacation -> Scott. I don't know ...
6 years, 9 months ago (2014-02-27 20:53:09 UTC) #3
brettw
TBR=thakis
6 years, 9 months ago (2014-02-27 21:24:35 UTC) #4
brettw
Committed patchset #1 manually as r253952 (presubmit successful).
6 years, 9 months ago (2014-02-27 22:46:46 UTC) #5
Nico
6 years, 9 months ago (2014-03-03 21:18:09 UTC) #6
Message was sent while issue was closed.
lgtm

https://codereview.chromium.org/179873008/diff/1/build/config/mac/BUILD.gn
File build/config/mac/BUILD.gn (right):

https://codereview.chromium.org/179873008/diff/1/build/config/mac/BUILD.gn#ne...
build/config/mac/BUILD.gn:30: # On Mac, this is used only for executables.
common.gypi says

                # Turn on position-independence (ASLR) for executables. When
                # PIE is on for the Chrome executables, the framework will
                # also be subject to ASLR.

which might be interesting to mention.

common.gypi also doesn't do this for valgrind builds – I guess you don't care
about valgrind yet?

Powered by Google App Engine
This is Rietveld 408576698