Issue 179853002: DevTools: Enable antialiasing in the pie chart.

Issue 179853002: DevTools: Enable antialiasing in the pie chart. (Closed)

Created:
6 years, 10 months ago by alph

Modified:
6 years, 9 months ago

Reviewers:
caseq, pfeldman, yurys

CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, alph+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

DevTools: Enable antialiasing in the pie chart. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=168025

Patch Set 1 #

Total comments: 1

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -1 line)			Patch
	M	Source/devtools/front_end/PieChart.js	View		1 chunk	+2 lines, -1 line	1 comment	Download

Messages

Total messages: 11 (0 generated)

Expand Messages | Collapse Messages

pfeldman

https://codereview.chromium.org/179853002/diff/1/Source/devtools/front_end/PieChart.js File Source/devtools/front_end/PieChart.js (right): https://codereview.chromium.org/179853002/diff/1/Source/devtools/front_end/PieChart.js#newcode68 Source/devtools/front_end/PieChart.js:68: // translate3d enables antialiasing for the slice. Is there ...

6 years, 10 months ago (2014-02-25 16:19:30 UTC) #2

alph

On 2014/02/25 16:19:30, pfeldman wrote: > https://codereview.chromium.org/179853002/diff/1/Source/devtools/front_end/PieChart.js > File Source/devtools/front_end/PieChart.js (right): > > https://codereview.chromium.org/179853002/diff/1/Source/devtools/front_end/PieChart.js#newcode68 > ...

6 years, 10 months ago (2014-02-25 17:25:40 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/alph@chromium.org/179853002/1

6 years, 10 months ago (2014-02-27 04:43:34 UTC) #5

commit-bot: I haz the power

The CQ bit was unchecked by commit-bot@chromium.org

6 years, 10 months ago (2014-02-27 06:33:50 UTC) #6

commit-bot: I haz the power

Retried try job too often on win_blink_rel for step(s) webkit_unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_blink_rel&number=29306

6 years, 10 months ago (2014-02-27 06:33:50 UTC) #7

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/alph@chromium.org/179853002/1

6 years, 9 months ago (2014-02-27 13:22:12 UTC) #9

pfeldman

6 years, 9 months ago (2014-03-06 04:07:14 UTC) #11

Message was sent while issue was closed.

A revert of this CL has been created in
https://codereview.chromium.org/188053004/ by pfeldman@chromium.org.

The reason for reverting is: This change introduced significant performance
penalty - paint time prevents timeline from animating even at 30 fps..

Expand Messages | Collapse Messages