Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 1798523003: Moved AppMenu ACTIVATED/DEACTIVATED ink drop handling in to MenuButton. (Closed)

Created:
4 years, 9 months ago by bruthig
Modified:
4 years, 9 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2661
Target Ref:
refs/pending/branch-heads/2661
Project:
chromium
Visibility:
Public.

Description

Moved AppMenu ACTIVATED/DEACTIVATED ink drop handling in to MenuButton. The AppMenuButton and the ToolbarActionView buttons were both handling the ink drop animating to/from the ACTIVATED/DEACTIVATED states. This change pushes that logic up in the common ancestor MenuButton. BUG=592058 TEST=MenuButtonTest.* TEST=ToolbarActionViewUnitTest.NoCrashWhenDestroyingToolbarActionViewThatHasAPressedLock Review URL: https://codereview.chromium.org/1778643002 Cr-Commit-Position: refs/heads/master@{#380626} (cherry picked from commit 3ead9e2c8b5d650d7d72868ab10f147a86642b97) Committed: https://chromium.googlesource.com/chromium/src/+/1143984d47db7f25de36cebfcc5c189e0231f2a2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+325 lines, -43 lines) Patch
M chrome/browser/ui/views/toolbar/app_menu_button.h View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/toolbar/app_menu_button.cc View 4 chunks +1 line, -20 lines 0 comments Download
M chrome/browser/ui/views/toolbar/toolbar_action_view.cc View 5 chunks +8 lines, -5 lines 0 comments Download
M chrome/browser/ui/views/toolbar/toolbar_action_view_unittest.cc View 2 chunks +60 lines, -1 line 0 comments Download
A ui/views/animation/test/test_ink_drop_delegate.h View 1 chunk +38 lines, -0 lines 0 comments Download
A ui/views/animation/test/test_ink_drop_delegate.cc View 1 chunk +24 lines, -0 lines 0 comments Download
M ui/views/controls/button/menu_button.h View 1 chunk +3 lines, -0 lines 0 comments Download
M ui/views/controls/button/menu_button.cc View 6 chunks +26 lines, -9 lines 0 comments Download
M ui/views/controls/button/menu_button_unittest.cc View 9 chunks +163 lines, -5 lines 0 comments Download
M ui/views/views.gyp View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
bruthig
4 years, 9 months ago (2016-03-13 20:55:38 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
1143984d47db7f25de36cebfcc5c189e0231f2a2.

Powered by Google App Engine
This is Rietveld 408576698