Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(192)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 179843003: Fix valgrind bot errors introduced in f84722e4777. (Closed)

Created:
6 years, 10 months ago by hal.canary
Modified:
6 years, 10 months ago
Reviewers:
robertphillips
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

Fix valgrind bot errors introduced in f84722e4777. NOTREECHECKS=true NOTRY=true Committed: http://code.google.com/p/skia/source/detail?r=13580

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M gyp/zlib.gyp View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
hal.canary
I'm still waiting on the trybot.
6 years, 10 months ago (2014-02-25 17:08:30 UTC) #1
robertphillips
lgtm
6 years, 10 months ago (2014-02-25 17:53:14 UTC) #2
hal.canary
The CQ bit was checked by halcanary@google.com
6 years, 10 months ago (2014-02-25 18:01:31 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/halcanary@google.com/179843003/1
6 years, 10 months ago (2014-02-25 18:01:32 UTC) #4
commit-bot: I haz the power
6 years, 10 months ago (2014-02-25 18:01:39 UTC) #5
Message was sent while issue was closed. 
Change committed as 13580

Powered by Google App Engine
This is Rietveld 408576698