Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2606)

Unified Diff: chrome/browser/invalidation/ticl_invalidation_service.h

Issue 179843002: Make invalidations work for Chrome OS Kiosk Apps. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix merge error leading to uninitialized memory access. Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/invalidation/ticl_invalidation_service.h
diff --git a/chrome/browser/invalidation/ticl_invalidation_service.h b/chrome/browser/invalidation/ticl_invalidation_service.h
index c5c2c53f35d00e0f4e5fc2aa3244992907716b25..c28e585d161810f6a90b4ac4730fb8c0d291888a 100644
--- a/chrome/browser/invalidation/ticl_invalidation_service.h
+++ b/chrome/browser/invalidation/ticl_invalidation_service.h
@@ -5,13 +5,15 @@
#ifndef CHROME_BROWSER_INVALIDATION_TICL_INVALIDATION_SERVICE_H_
#define CHROME_BROWSER_INVALIDATION_TICL_INVALIDATION_SERVICE_H_
+#include <string>
+
#include "base/memory/scoped_ptr.h"
#include "base/threading/non_thread_safe.h"
#include "base/timer/timer.h"
+#include "chrome/browser/invalidation/invalidation_auth_provider.h"
#include "chrome/browser/invalidation/invalidation_logger.h"
#include "chrome/browser/invalidation/invalidation_service.h"
#include "chrome/browser/invalidation/invalidator_storage.h"
-#include "chrome/browser/signin/signin_manager.h"
#include "components/keyed_service/core/keyed_service.h"
#include "components/signin/core/profile_oauth2_token_service.h"
#include "google_apis/gaia/oauth2_token_service.h"
@@ -34,11 +36,10 @@ class TiclInvalidationService : public base::NonThreadSafe,
public InvalidationService,
public OAuth2TokenService::Consumer,
public OAuth2TokenService::Observer,
- public SigninManagerBase::Observer,
+ public InvalidationAuthProvider::Observer,
public syncer::InvalidationHandler {
public:
- TiclInvalidationService(SigninManagerBase* signin,
- ProfileOAuth2TokenService* oauth2_token_service,
+ TiclInvalidationService(scoped_ptr<InvalidationAuthProvider> auth_provider,
Profile* profile);
virtual ~TiclInvalidationService();
@@ -58,6 +59,7 @@ class TiclInvalidationService : public base::NonThreadSafe,
virtual InvalidationLogger* GetInvalidationLogger() OVERRIDE;
virtual void RequestDetailedStatus(
base::Callback<void(const base::DictionaryValue&)> caller) OVERRIDE;
+ virtual InvalidationAuthProvider* GetInvalidationAuthProvider() OVERRIDE;
void RequestAccessToken();
@@ -74,8 +76,8 @@ class TiclInvalidationService : public base::NonThreadSafe,
virtual void OnRefreshTokenAvailable(const std::string& account_id) OVERRIDE;
virtual void OnRefreshTokenRevoked(const std::string& account_id) OVERRIDE;
- // SigninManagerBase::Observer implementation.
- virtual void GoogleSignedOut(const std::string& username) OVERRIDE;
+ // InvalidationAuthProvider::Observer implementation.
+ virtual void OnInvalidationAuthLogout() OVERRIDE;
// syncer::InvalidationHandler implementation.
virtual void OnInvalidatorStateChange(
@@ -105,11 +107,9 @@ class TiclInvalidationService : public base::NonThreadSafe,
void StartInvalidator(InvalidationNetworkChannel network_channel);
void UpdateInvalidatorCredentials();
void StopInvalidator();
- void Logout();
Profile *const profile_;
- SigninManagerBase *const signin_manager_;
- ProfileOAuth2TokenService *const oauth2_token_service_;
+ scoped_ptr<InvalidationAuthProvider> auth_provider_;
scoped_ptr<syncer::InvalidatorRegistrar> invalidator_registrar_;
scoped_ptr<InvalidatorStorage> invalidator_storage_;

Powered by Google App Engine
This is Rietveld 408576698