chrome/browser/extensions/api/push_messaging/push_messaging_invalidation_handler_unittest.cc - Issue 179843002: Make invalidations work for Chrome OS Kiosk Apps.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/push_messaging/push_messaging_invalidation_handler_unittest.cc

Issue 179843002: Make invalidations work for Chrome OS Kiosk Apps. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fix merge error leading to uninitialized memory access. Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/push_messaging/push_messaging_api.cc ('k') | chrome/browser/invalidation/device_invalidation_auth_provider_chromeos.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/push_messaging/push_messaging_invalidation_handler_unittest.cc

diff --git a/chrome/browser/extensions/api/push_messaging/push_messaging_invalidation_handler_unittest.cc b/chrome/browser/extensions/api/push_messaging/push_messaging_invalidation_handler_unittest.cc

index 34fb9f20418802d0bf2f6583e71b4baefc81e599..b0cad99a2a6cc7d6bc6e7c440a009db422401261 100644

--- a/chrome/browser/extensions/api/push_messaging/push_messaging_invalidation_handler_unittest.cc

+++ b/chrome/browser/extensions/api/push_messaging/push_messaging_invalidation_handler_unittest.cc

@@ -14,10 +14,10 @@

#include "testing/gmock/include/gmock/gmock.h"

#include "testing/gtest/include/gtest/gtest.h"

-using ::testing::_;

using ::testing::NotNull;

using ::testing::SaveArg;

using ::testing::StrictMock;

+using ::testing::_;

namespace extensions {

@@ -38,6 +38,8 @@ class MockInvalidationService : public invalidation::InvalidationService {

MOCK_METHOD0(GetInvalidationLogger, invalidation::InvalidationLogger*());

MOCK_METHOD1(RequestDetailedStatus,

void(base::Callback<void(const base::DictionaryValue&)>));

+ MOCK_METHOD0(GetInvalidationAuthProvider,

+ invalidation::InvalidationAuthProvider*());

private:

DISALLOW_COPY_AND_ASSIGN(MockInvalidationService);