Make invalidations work for Chrome OS Kiosk Apps.

chrome/browser/services/gcm/gcm_profile_service.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/services/gcm/gcm_profile_service.h"
 
 #include <algorithm>
 #include <string>
 #include <vector>
 
@@ skipping 525 matching lines @@
       user_prefs::PrefRegistrySyncable::UNSYNCABLE_PREF);
   registry->RegisterListPref(
       prefs::kGCMRegisteredAppIDs,
       user_prefs::PrefRegistrySyncable::UNSYNCABLE_PREF);
 }
 
 GCMProfileService::GCMProfileService(Profile* profile)
     : profile_(profile),
       gcm_client_ready_(false),
       weak_ptr_factory_(this) {
-  DCHECK(!profile->IsOffTheRecord());
+  DCHECK(!profile || !profile->IsOffTheRecord());

[jianli, 2014/03/20 16:47:30]

GCMProfileService depends on profile. Even you make this DCHECK work for the
case without profile, you will get the crash later on when profile is accessed.

[Mattias Nissler (ping if slow), 2014/03/20 16:51:26]

I added this just to get FakeGCMProfileService in
gcm_invalidation_bridge_unittest.cc going, which needs to call the ctor but
doesn't actually rely on having a valid Profile.

I prefer tests to work with out the heavy-weight dependency to TestingProfile
where possible, but I'm not going to complain if you tell me to spin up a
TestingProfile just for getting past this DCHECK :)

[jianli, 2014/03/20 16:56:28]

Skipping the check in GCMProfileService constructor sounds more like hack to me.
I think it is better to create a TestingProfile in order to make the test be
close to the real scenarion as much as possible.

[Mattias Nissler (ping if slow), 2014/03/20 17:07:37]

I'd agree if we were talking about an integration test that exercises
GCMInvalidationBridge in context, but this is a unit test that is using a *fake*
implementation of GCMProfileService. Thus, there can't be any expectation of it
resembling any real-life scenario.

Anyways, I'm not going to fight over this. I'll upload a CL that restores the
TestingProfile boilerplate in a second.

 }
 
 GCMProfileService::~GCMProfileService() {
 }
 
 void GCMProfileService::Initialize(
     scoped_ptr<GCMClientFactory> gcm_client_factory) {
   registrar_.Add(this,
                  chrome::NOTIFICATION_PROFILE_DESTROYED,
                  content::Source<Profile>(profile_));
@@ skipping 660 matching lines @@
 
   request_gcm_statistics_callback_.Run(stats);
 }
 
 // static
 const char* GCMProfileService::GetPersistentRegisterKeyForTesting() {
   return kRegistrationKey;
 }
 
 }  // namespace gcm