Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1798413003: [Editing][CodeHealth] Use w3c testharness in editing/seletion/extend-by-* (Closed)

Created:
4 years, 9 months ago by yoichio
Modified:
4 years, 9 months ago
Reviewers:
yosin_UTC9
CC:
blink-reviews, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Editing][CodeHealth] Use w3c testharness in editing/seletion/extend-by-* Use w3c testharness in LayoutTests/editing/selection/ extend-by-character-001.html extend-by-character-002.html extend-by-character-003.html extend-by-character-004.html extend-by-character-005.html extend-by-word-001.html BUG= Committed: https://crrev.com/b7a7753007868ebc3e4fa89742585e9589c813ef Cr-Commit-Position: refs/heads/master@{#381673}

Patch Set 1 #

Patch Set 2 : update #

Total comments: 1

Patch Set 3 : move #

Patch Set 4 : fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+159 lines, -2451 lines) Patch
M third_party/WebKit/LayoutTests/editing/selection/extend-by-character-001.html View 1 2 1 chunk +0 lines, -37 lines 0 comments Download
M third_party/WebKit/LayoutTests/editing/selection/extend-by-character-002.html View 1 2 1 chunk +0 lines, -40 lines 0 comments Download
M third_party/WebKit/LayoutTests/editing/selection/extend-by-character-003.html View 1 2 1 chunk +0 lines, -40 lines 0 comments Download
M third_party/WebKit/LayoutTests/editing/selection/extend-by-character-004.html View 1 2 1 chunk +0 lines, -40 lines 0 comments Download
M third_party/WebKit/LayoutTests/editing/selection/extend-by-character-005.html View 1 2 1 chunk +0 lines, -41 lines 0 comments Download
M third_party/WebKit/LayoutTests/editing/selection/extend-by-word-001.html View 1 2 1 chunk +0 lines, -45 lines 0 comments Download
A third_party/WebKit/LayoutTests/editing/selection/modify_extend/extend-by-character-001.html View 1 2 3 1 chunk +22 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/editing/selection/modify_extend/extend-by-character-002.html View 1 2 3 1 chunk +28 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/editing/selection/modify_extend/extend-by-character-003.html View 1 2 3 1 chunk +28 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/editing/selection/modify_extend/extend-by-character-004.html View 1 2 3 1 chunk +27 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/editing/selection/modify_extend/extend-by-character-005.html View 1 2 3 1 chunk +29 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/editing/selection/modify_extend/extend-by-word-001.html View 1 2 3 1 chunk +25 lines, -0 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/linux/editing/selection/extend-by-character-001-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/linux/editing/selection/extend-by-character-001-expected.txt View 1 chunk +0 lines, -25 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/linux/editing/selection/extend-by-character-002-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/linux/editing/selection/extend-by-character-002-expected.txt View 1 chunk +0 lines, -63 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/linux/editing/selection/extend-by-character-003-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/linux/editing/selection/extend-by-character-003-expected.txt View 1 chunk +0 lines, -188 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/linux/editing/selection/extend-by-character-004-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/linux/editing/selection/extend-by-character-004-expected.txt View 1 chunk +0 lines, -92 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/linux/editing/selection/extend-by-character-005-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/linux/editing/selection/extend-by-character-005-expected.txt View 1 chunk +0 lines, -346 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/linux/editing/selection/extend-by-word-001-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/linux/editing/selection/extend-by-word-001-expected.txt View 1 chunk +0 lines, -22 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac/editing/selection/extend-by-character-001-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac/editing/selection/extend-by-character-001-expected.txt View 1 chunk +0 lines, -25 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac/editing/selection/extend-by-character-002-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac/editing/selection/extend-by-character-002-expected.txt View 1 chunk +0 lines, -63 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac/editing/selection/extend-by-character-003-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac/editing/selection/extend-by-character-003-expected.txt View 1 chunk +0 lines, -188 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac/editing/selection/extend-by-character-004-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac/editing/selection/extend-by-character-004-expected.txt View 1 chunk +0 lines, -92 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac/editing/selection/extend-by-character-005-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac/editing/selection/extend-by-character-005-expected.txt View 1 chunk +0 lines, -346 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac/editing/selection/extend-by-word-001-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac/editing/selection/extend-by-word-001-expected.txt View 1 chunk +0 lines, -22 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/win/editing/selection/extend-by-character-001-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/win/editing/selection/extend-by-character-001-expected.txt View 1 chunk +0 lines, -25 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/win/editing/selection/extend-by-character-002-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/win/editing/selection/extend-by-character-002-expected.txt View 1 chunk +0 lines, -63 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/win/editing/selection/extend-by-character-003-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/win/editing/selection/extend-by-character-003-expected.txt View 1 chunk +0 lines, -188 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/win/editing/selection/extend-by-character-004-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/win/editing/selection/extend-by-character-004-expected.txt View 1 chunk +0 lines, -92 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/win/editing/selection/extend-by-character-005-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/win/editing/selection/extend-by-character-005-expected.txt View 1 chunk +0 lines, -346 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/win/editing/selection/extend-by-word-001-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/win/editing/selection/extend-by-word-001-expected.txt View 1 chunk +0 lines, -22 lines 0 comments Download

Messages

Total messages: 21 (9 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1798413003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1798413003/20001
4 years, 9 months ago (2016-03-17 02:02:02 UTC) #2
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 9 months ago (2016-03-17 03:03:22 UTC) #4
yoichio
4 years, 9 months ago (2016-03-17 04:11:38 UTC) #7
yosin_UTC9
https://codereview.chromium.org/1798413003/diff/20001/third_party/WebKit/LayoutTests/editing/selection/extend-by-character-001.html File third_party/WebKit/LayoutTests/editing/selection/extend-by-character-001.html (right): https://codereview.chromium.org/1798413003/diff/20001/third_party/WebKit/LayoutTests/editing/selection/extend-by-character-001.html#newcode1 third_party/WebKit/LayoutTests/editing/selection/extend-by-character-001.html:1: <!DOCTYPE html> Could you move them into editing/selection/modify_extend/? Since, ...
4 years, 9 months ago (2016-03-17 04:25:41 UTC) #8
yoichio
On 2016/03/17 at 04:25:41, yosin wrote: > https://codereview.chromium.org/1798413003/diff/20001/third_party/WebKit/LayoutTests/editing/selection/extend-by-character-001.html > File third_party/WebKit/LayoutTests/editing/selection/extend-by-character-001.html (right): > > https://codereview.chromium.org/1798413003/diff/20001/third_party/WebKit/LayoutTests/editing/selection/extend-by-character-001.html#newcode1 ...
4 years, 9 months ago (2016-03-17 05:15:03 UTC) #9
yosin_UTC9
lgtm
4 years, 9 months ago (2016-03-17 05:51:59 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1798413003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1798413003/40001
4 years, 9 months ago (2016-03-17 05:52:12 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/196528)
4 years, 9 months ago (2016-03-17 07:07:25 UTC) #14
yoichio
4 years, 9 months ago (2016-03-17 07:40:41 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1798413003/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1798413003/60001
4 years, 9 months ago (2016-03-17 07:40:50 UTC) #18
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 9 months ago (2016-03-17 08:54:32 UTC) #19
commit-bot: I haz the power
4 years, 9 months ago (2016-03-17 08:55:40 UTC) #21
Message was sent while issue was closed. 
Patchset 4 (id:??) landed as
https://crrev.com/b7a7753007868ebc3e4fa89742585e9589c813ef
Cr-Commit-Position: refs/heads/master@{#381673}

Powered by Google App Engine
This is Rietveld 408576698