[iOS] Exclude tests with dependency on ASSERT_DEATH on iOS.

[iOS] Exclude tests with dependency on ASSERT_DEATH on iOS.

Those tests do not compile on iOS as ASSERT_DEATH is not defined
instead they should use ASSERT_DEATH_IF_SUPPORTED. Disable them
until the underlying issue if fixed in third-party library.

BUG=459705
Committed: https://crrev.com/90cbedb35b1b6a97beb01f4606db5853992ae06f
Cr-Commit-Position: refs/heads/master@{#381705}

[sdefresne, 2016-03-15 13:33:11]

sdefresne@chromium.org changed reviewers:
+ estade@chromium.org

[sdefresne, 2016-03-15 13:33:12]

Please take a look.

[Evan Stade, 2016-03-15 20:12:11]

On 2016/03/15 13:33:12, sdefresne wrote:
> Please take a look.

not all of the tests use ASSERT_DEATH. Could we do something like defining
ASSERT_DEATH to a no-op on ios?

[sdefresne, 2016-03-16 14:08:27]

On 2016/03/15 at 20:12:11, estade wrote:
> On 2016/03/15 13:33:12, sdefresne wrote:
> > Please take a look.
> 
> not all of the tests use ASSERT_DEATH. Could we do something like defining
ASSERT_DEATH to a no-op on ios?

Tests are not supposed to use ASSERT_DEATH directly but instead they should use
ASSERT_DEATH_IF_SUPPORTED:
https://code.google.com/p/chromium/codesearch#chromium/src/testing/gtest/incl...

So, I guess we can change the test to use the correct macro instead. I can send
you a CL doing that if you tell me in which repository I'm supposed to make the
change (as libadressinput is a third-party, I'm not sure I can make the change
in the Chromium checkout directly). Should I send a push request to
https://github.com/googlei18n/libaddressinput?

In the interim, can we land this CL? libaddressinput_unittests are not run on
iOS when building with gyp, so currently those tests are not run on iOS. I'd say
that building the target, even with one test suite disabled would be an
improvement. Then once the change lands in libaddressinput, we can revert this
change (I'm trying to fix the build of iOS using gn and if possible I'd prefer
not to be blocked on third-party developers).

WDYT?

[sdefresne, 2016-03-16 14:09:43]

Description was changed from

==========
[iOS] Exclude tests with dependency on ASSERT_DEATH on iOS.

Those tests do not compile on iOS (ASSERT_DEATH is not defined),
so do not build them.

BUG=459705
==========

to

==========
[iOS] Exclude tests with dependency on ASSERT_DEATH on iOS.

Those tests do not compile on iOS as ASSERT_DEATH is not defined
instead they should use ASSERT_DEATH_IF_SUPPORTED. Disable them
until the underlying issue if fixed in third-party library.

BUG=459705
==========

[Evan Stade, 2016-03-16 20:52:02]

estade@chromium.org changed reviewers:
+ rouslan@chromium.org

[Evan Stade, 2016-03-16 20:52:03]

all of the above sgtm. lgtm

+rouslan

[please use gerrit instead, 2016-03-16 21:21:58]

lgtm % a comment change:

Please put a "TODO(rouslan)" and the bug number that's tracking this problem in
the comment. (Please file a bug against me.)

I will fix this issue in the upstream library.

[sdefresne, 2016-03-17 13:22:54]

The CQ bit was checked by sdefresne@chromium.org

[sdefresne, 2016-03-17 13:22:54]

The patchset sent to the CQ was uploaded after l-g-t-m from
rouslan@chromium.org, estade@chromium.org
Link to the patchset: https://codereview.chromium.org/1798413002/#ps20001
(title: "Add TODO(rouslan)")

[commit-bot: I haz the power, 2016-03-17 13:23:08]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1798413002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1798413002/20001

[commit-bot: I haz the power, 2016-03-17 14:41:07]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-03-17 14:42:22]

Description was changed from

==========
[iOS] Exclude tests with dependency on ASSERT_DEATH on iOS.

Those tests do not compile on iOS as ASSERT_DEATH is not defined
instead they should use ASSERT_DEATH_IF_SUPPORTED. Disable them
until the underlying issue if fixed in third-party library.

BUG=459705
==========

to

==========
[iOS] Exclude tests with dependency on ASSERT_DEATH on iOS.

Those tests do not compile on iOS as ASSERT_DEATH is not defined
instead they should use ASSERT_DEATH_IF_SUPPORTED. Disable them
until the underlying issue if fixed in third-party library.

BUG=459705

Committed: https://crrev.com/90cbedb35b1b6a97beb01f4606db5853992ae06f
Cr-Commit-Position: refs/heads/master@{#381705}
==========

[commit-bot: I haz the power, 2016-03-17 14:42:24]

Patchset 2 (id:??) landed as
https://crrev.com/90cbedb35b1b6a97beb01f4606db5853992ae06f
Cr-Commit-Position: refs/heads/master@{#381705}