chrome/test/base/tracing_browsertest.cc - Issue 1798393002: Disabling flaking test SingleProcessTracingBrowserTest.TestMemoryInfra on Windows.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/base/tracing_browsertest.cc

Issue 1798393002: Disabling flaking test SingleProcessTracingBrowserTest.TestMemoryInfra on Windows. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/test/base/tracing_browsertest.cc

diff --git a/chrome/test/base/tracing_browsertest.cc b/chrome/test/base/tracing_browsertest.cc

index d29f07c007f860864f3c3ff1cf69a389137425a6..496d4586d5541566d0a614d4fdbda3499c50d104 100644

--- a/chrome/test/base/tracing_browsertest.cc

+++ b/chrome/test/base/tracing_browsertest.cc

@@ -170,7 +170,8 @@ IN_PROC_BROWSER_TEST_F(TracingBrowserTest, TestMemoryInfra) {

// Single-process mode.

// Flaky (leaking) on linux_chromium_asan_rel_ng: https://crbug.com/585026

-#if defined(ADDRESS_SANITIZER)

+// and Windows https://crbug.com/594884

+#if defined(ADDRESS_SANITIZER) || defined(OS_WIN)

#define MAYBE_TestMemoryInfra DISABLED_TestMemoryInfra

#else

#define MAYBE_TestMemoryInfra TestMemoryInfra

« no previous file with comments | « no previous file | no next file » | no next file with comments »