Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(137)

Issue 1798303002: dart2js: Adds support for custom elements in CPS. (Closed)

Created:
4 years, 9 months ago by Harry Terkelsen
Modified:
4 years, 9 months ago
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : fixed other test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -17 lines) Patch
M pkg/compiler/lib/src/cps_ir/cps_ir_builder_task.dart View 5 chunks +37 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/cps_ir/use_field_initializers.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js_native/dart2js_native.status View 1 1 chunk +0 lines, -1 line 0 comments Download
M tests/html/html.status View 1 chunk +0 lines, -11 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Harry Terkelsen
4 years, 9 months ago (2016-03-14 23:31:40 UTC) #2
sra1
lgtm
4 years, 9 months ago (2016-03-14 23:45:07 UTC) #3
Siggi Cherem (dart-lang)
lgtm
4 years, 9 months ago (2016-03-14 23:53:42 UTC) #4
Harry Terkelsen
4 years, 9 months ago (2016-03-14 23:57:50 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
983569525fbe894f49c45a7ae546cecd1d5cb622 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698