Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(207)

Issue 1798273002: Remove configuration policy from chrome build files. (Closed)

Created:
4 years, 9 months ago by brettw
Modified:
4 years, 9 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@policy_chrome_defines
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove configuration policy from chrome build files. The define was removed from src/chrome source files in https://codereview.chromium.org/1786263002/, this patch only touches the build files in src/chrome. Build updates outside of this directory will be updated in subsequent passes. BUG=594261 Committed: https://crrev.com/db234c06ff6c308520594591fa54f80b08411888 Cr-Commit-Position: refs/heads/master@{#382614}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : merge #

Total comments: 3

Patch Set 4 : review comments + merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+174 lines, -462 lines) Patch
M chrome/BUILD.gn View 1 2 2 chunks +2 lines, -6 lines 0 comments Download
M chrome/android/BUILD.gn View 1 2 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/android/chrome_apk.gyp View 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/android/chrome_public_apk_tmpl.gni View 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/android/java/AndroidManifest.xml View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/app/BUILD.gn View 2 chunks +1 line, -4 lines 0 comments Download
M chrome/browser/BUILD.gn View 1 2 4 chunks +12 lines, -44 lines 0 comments Download
M chrome/browser/extensions/BUILD.gn View 2 chunks +1 line, -11 lines 0 comments Download
M chrome/browser/policy/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
D chrome/browser/policy/profile_policy_connector_stub.cc View 1 chunk +0 lines, -40 lines 0 comments Download
M chrome/browser/ui/BUILD.gn View 1 2 2 chunks +1 line, -6 lines 0 comments Download
M chrome/chrome.gyp View 4 chunks +3 lines, -9 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 2 12 chunks +60 lines, -107 lines 0 comments Download
M chrome/chrome_browser_extensions.gypi View 1 2 5 chunks +7 lines, -16 lines 0 comments Download
M chrome/chrome_browser_ui.gypi View 1 2 4 chunks +7 lines, -14 lines 0 comments Download
M chrome/chrome_common.gypi View 1 2 2 chunks +1 line, -5 lines 0 comments Download
M chrome/chrome_dll.gypi View 1 2 3 3 chunks +4 lines, -14 lines 0 comments Download
M chrome/chrome_exe.gypi View 1 2 4 chunks +2 lines, -14 lines 0 comments Download
M chrome/chrome_process_finder.gypi View 1 chunk +1 line, -7 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 2 6 chunks +16 lines, -27 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 2 17 chunks +25 lines, -60 lines 0 comments Download
M chrome/common/BUILD.gn View 1 2 2 chunks +1 line, -3 lines 0 comments Download
M chrome/policy.gypi View 1 chunk +19 lines, -23 lines 0 comments Download
M chrome/test/BUILD.gn View 1 2 3 8 chunks +11 lines, -38 lines 0 comments Download

Messages

Total messages: 23 (10 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1798273002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1798273002/1
4 years, 9 months ago (2016-03-14 23:09:41 UTC) #2
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_compile_dbg_ng/builds/173142)
4 years, 9 months ago (2016-03-14 23:26:46 UTC) #4
brettw
Sorry in advance, some of the GYP changes will be difficult to make sense of ...
4 years, 9 months ago (2016-03-15 18:07:53 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1798273002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1798273002/20001
4 years, 9 months ago (2016-03-15 18:08:30 UTC) #8
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 9 months ago (2016-03-15 19:49:03 UTC) #10
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1798273002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1798273002/40001
4 years, 9 months ago (2016-03-21 22:22:26 UTC) #12
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 9 months ago (2016-03-21 23:08:54 UTC) #14
Andrew T Wilson (Slow)
LGTM https://codereview.chromium.org/1798273002/diff/40001/chrome/chrome_dll.gypi File chrome/chrome_dll.gypi (left): https://codereview.chromium.org/1798273002/diff/40001/chrome/chrome_dll.gypi#oldcode409 chrome/chrome_dll.gypi:409: 'policy_path_parser', Did we lose the dependency on policy_path_parser? ...
4 years, 9 months ago (2016-03-22 00:01:27 UTC) #15
brettw
https://codereview.chromium.org/1798273002/diff/40001/chrome/chrome_dll.gypi File chrome/chrome_dll.gypi (left): https://codereview.chromium.org/1798273002/diff/40001/chrome/chrome_dll.gypi#oldcode409 chrome/chrome_dll.gypi:409: 'policy_path_parser', Oh yeah, I got confused because it's listed ...
4 years, 9 months ago (2016-03-22 17:17:44 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1798273002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1798273002/60001
4 years, 9 months ago (2016-03-22 17:18:04 UTC) #19
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 9 months ago (2016-03-22 18:19:50 UTC) #20
commit-bot: I haz the power
Patchset 4 (id:??) landed as https://crrev.com/db234c06ff6c308520594591fa54f80b08411888 Cr-Commit-Position: refs/heads/master@{#382614}
4 years, 9 months ago (2016-03-22 18:21:09 UTC) #22
dgozman
4 years, 9 months ago (2016-03-22 21:16:07 UTC) #23
Message was sent while issue was closed.
A revert of this CL (patchset #4 id:60001) has been created in
https://codereview.chromium.org/1818423003/ by dgozman@chromium.org.

The reason for reverting is: Speculative revert: could have caused the Win8 GN
build failures. See crbug.com/597032.

Powered by Google App Engine
This is Rietveld 408576698