Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(275)

Unified Diff: third_party/WebKit/Source/core/style/ComputedStyle.h

Issue 1798263002: Rename isTreatedAsOrStackingContext to isStacked (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Markdown, isStacked, paintAllPhasesAtomically Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/style/ComputedStyle.h
diff --git a/third_party/WebKit/Source/core/style/ComputedStyle.h b/third_party/WebKit/Source/core/style/ComputedStyle.h
index 0e36cfe64a9afdf16aa4904146c6ec6bdc8eba6d..2262a8b773d28591cf5763981a649259540fa795 100644
--- a/third_party/WebKit/Source/core/style/ComputedStyle.h
+++ b/third_party/WebKit/Source/core/style/ComputedStyle.h
@@ -1284,30 +1284,9 @@ public:
// a containing stacking context defines in which order the stacking contexts
// below are painted. In Blink, a stacking context is defined by non-auto
// z-index'. This invariant is enforced by the logic in StyleAdjuster
- // See CSS 2.1, Appendix E for more details.
+ // See CSS 2.1, Appendix E (https://www.w3.org/TR/CSS21/zindex.html) for more details.
bool isStackingContext() const { return !hasAutoZIndex(); }
- // Some elements are "treated as if they create a new stacking context" for
- // the purpose of painting and hit testing. This means that they are painted
- // atomically (like a stacking context) but they don't determine the
- // stacking of the elements underneath them (stacking contexts or elements
- // "treated as stacking context"). See PaintLayerStackingNode for
- // more about painting order.
- bool isTreatedAsStackingContext() const
- {
- // FIXME: Floating objects are also considered stacking contexts.
- return position() != StaticPosition;
- }
-
- // Returns true if an element is a stacking context or "treated as a
- // stacking context". Most callers care about this as it follows the
- // painting order where we collect anything that returns true from this
- // function under the enclosing stacking context.
- bool isTreatedAsOrStackingContext() const
- {
- return isStackingContext() || isTreatedAsStackingContext();
- }
-
bool hasAutoZIndex() const { return m_box->hasAutoZIndex(); }
void setHasAutoZIndex() { SET_VAR(m_box, m_hasAutoZIndex, true); SET_VAR(m_box, m_zIndex, 0); }
int zIndex() const { return m_box->zIndex(); }

Powered by Google App Engine
This is Rietveld 408576698