Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(652)

Issue 1798253003: Timeline: get collapsible row groups on FlameChart out of experiment (Closed)

Created:
4 years, 9 months ago by caseq
Modified:
4 years, 9 months ago
Reviewers:
paulirish, alph, pfeldman
CC:
apavlov+blink_chromium.org, blink-reviews, caseq+blink_chromium.org, chromium-reviews, devtools-reviews_chromium.org, kozyatinskiy+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, pfeldman, sergeyv+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Timeline: get collapsible row groups out of experiment Also, put rasterizer threads on top of main thread events. Committed: https://crrev.com/ae2828e77c06393d972de8014bdf0798cc1a9b55 Cr-Commit-Position: refs/heads/master@{#381649}

Patch Set 1 #

Patch Set 2 : remove experiment from Main.js #

Patch Set 3 : cleanup Header entry type #

Patch Set 4 : rebased test as "Main Thread" header is no longer an entry #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -61 lines) Patch
M third_party/WebKit/LayoutTests/inspector/tracing/timeline-js-blackboxing-expected.txt View 1 2 3 1 chunk +23 lines, -25 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/main/Main.js View 1 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/timeline/TimelineFlameChart.js View 1 2 5 chunks +10 lines, -35 lines 0 comments Download

Messages

Total messages: 23 (10 generated)
caseq
4 years, 9 months ago (2016-03-15 00:03:40 UTC) #3
caseq
ping
4 years, 9 months ago (2016-03-16 23:02:24 UTC) #4
alph
Could you split these two changes, because someone may be ok with one and against ...
4 years, 9 months ago (2016-03-16 23:30:40 UTC) #5
caseq
On 2016/03/16 23:30:40, alph wrote: > Could you split these two changes, because someone may ...
4 years, 9 months ago (2016-03-16 23:43:43 UTC) #6
alph
lg​tm
4 years, 9 months ago (2016-03-16 23:48:00 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1798253003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1798253003/40001
4 years, 9 months ago (2016-03-16 23:48:42 UTC) #9
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years, 9 months ago (2016-03-16 23:48:45 UTC) #11
paulirish
lgtm
4 years, 9 months ago (2016-03-16 23:54:24 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1798253003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1798253003/40001
4 years, 9 months ago (2016-03-16 23:55:59 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/196453)
4 years, 9 months ago (2016-03-17 01:24:46 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1798253003/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1798253003/60001
4 years, 9 months ago (2016-03-17 01:42:54 UTC) #19
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 9 months ago (2016-03-17 02:49:06 UTC) #21
commit-bot: I haz the power
4 years, 9 months ago (2016-03-17 02:50:00 UTC) #23
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/ae2828e77c06393d972de8014bdf0798cc1a9b55
Cr-Commit-Position: refs/heads/master@{#381649}

Powered by Google App Engine
This is Rietveld 408576698