Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 1798223002: Fix visible range of local variables in 'for' loops. (Closed)

Created:
4 years, 9 months ago by scheglov
Modified:
4 years, 9 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+131 lines, -28 lines) Patch
M pkg/analysis_server/test/services/refactoring/rename_local_test.dart View 1 chunk +26 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/src/dart/element/builder.dart View 3 chunks +14 lines, -7 lines 0 comments Download
M pkg/analyzer/test/generated/all_the_rest_test.dart View 10 chunks +91 lines, -21 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
scheglov
4 years, 9 months ago (2016-03-14 21:38:12 UTC) #1
Brian Wilkerson
LGTM
4 years, 9 months ago (2016-03-14 21:40:37 UTC) #2
scheglov
4 years, 9 months ago (2016-03-14 21:43:20 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
8398960fb10dc4f47a36a083a4330978f3e81330 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698