Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(735)

Unified Diff: third_party/WebKit/Source/devtools/front_end/sdk/HAREntry.js

Issue 1798173003: [DevTools] Added serverIPaddress to HAR output (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Updated Tests Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/sdk/HAREntry.js
diff --git a/third_party/WebKit/Source/devtools/front_end/sdk/HAREntry.js b/third_party/WebKit/Source/devtools/front_end/sdk/HAREntry.js
index ce3591f89d39f672504839da11266265bb3b1890..4c573ff17c7d346541aaf08ea14f7a5f89c1e0d9 100644
--- a/third_party/WebKit/Source/devtools/front_end/sdk/HAREntry.js
+++ b/third_party/WebKit/Source/devtools/front_end/sdk/HAREntry.js
@@ -49,13 +49,20 @@ WebInspector.HAREntry.prototype = {
*/
build: function()
{
+ var ipAddress = this._request.remoteAddress();
pfeldman 2016/03/16 00:10:26 is this required field?
allada 2016/03/16 23:28:02 No, it is optional. From: https://dvcs.w3.org/hg/w
+ var portPositionInString = ipAddress.lastIndexOf(":");
+ if (portPositionInString) {
pfeldman 2016/03/16 00:10:26 drop {}
allada 2016/03/16 23:28:02 Done.
+ ipAddress = ipAddress.substr(0, portPositionInString);
+ }
+
var entry = {
startedDateTime: WebInspector.HARLog.pseudoWallTime(this._request, this._request.startTime),
time: this._request.timing ? WebInspector.HAREntry._toMilliseconds(this._request.duration) : 0,
request: this._buildRequest(),
response: this._buildResponse(),
cache: { }, // Not supported yet.
- timings: this._buildTimings()
+ timings: this._buildTimings(),
+ serverIPAddress: ipAddress
};
if (this._request.connectionId !== "0")

Powered by Google App Engine
This is Rietveld 408576698