[DevTools] Removed __defineGetter__ from InjectedScriptSource.js

[DevTools] Removed __defineGetter__ from InjectedScriptSource.js

All Command Line API methods were splitted into common methods and getters methods. V8WindowCustom binding calls getters method by itself.

Check of existance Command Line API method on global object can be removed from inScopeVariable function inside constructor because V8CustomBinding wouldn't be called if it's redefined by users.

BUG=593537
R=dgozman@chromium.org, pfeldman@chromium.org

Committed: https://crrev.com/f48b656630e08f24394cf69fea53b4fd2ae0f59f
Cr-Commit-Position: refs/heads/master@{#381143}

[kozy, 2016-03-14 18:59:42]

ptal

[dgozman, 2016-03-14 19:08:06]

lgtm

[kozy, 2016-03-14 19:08:29]

Description was changed from

==========
[DevTools] Removed __defineGetter__ from InjectedScriptSource.js

All Command Line API methods were splitted into common methods and getters
methods. V8WindowCustom binding calls getters method by itself.

Check of existance Command Line API method on global object can be removed from
inScopeVariable function inside constructor because V8CustomBinding wouldn't be
called if it's redefined by users.

BUG=593537
R=dgozman@chromium.org
==========

to

==========
[DevTools] Removed __defineGetter__ from InjectedScriptSource.js

All Command Line API methods were splitted into common methods and getters
methods. V8WindowCustom binding calls getters method by itself.

Check of existance Command Line API method on global object can be removed from
inScopeVariable function inside constructor because V8CustomBinding wouldn't be
called if it's redefined by users.

BUG=593537
R=dgozman@chromium.org
==========

[kozy, 2016-03-14 19:08:29]

kozyatinskiy@chromium.org changed reviewers:
+ pfeldman@chromium.org

[kozy, 2016-03-14 19:08:45]

Description was changed from

==========
[DevTools] Removed __defineGetter__ from InjectedScriptSource.js

All Command Line API methods were splitted into common methods and getters
methods. V8WindowCustom binding calls getters method by itself.

Check of existance Command Line API method on global object can be removed from
inScopeVariable function inside constructor because V8CustomBinding wouldn't be
called if it's redefined by users.

BUG=593537
R=dgozman@chromium.org
==========

to

==========
[DevTools] Removed __defineGetter__ from InjectedScriptSource.js

All Command Line API methods were splitted into common methods and getters
methods. V8WindowCustom binding calls getters method by itself.

Check of existance Command Line API method on global object can be removed from
inScopeVariable function inside constructor because V8CustomBinding wouldn't be
called if it's redefined by users.

BUG=593537
R=dgozman@chromium.org, pfeldman@chromium.org
==========

[kozy, 2016-03-14 19:10:37]

Pavel, ptal. I need owner review for 
/third_party/WebKit/Source/bindings/core/v8/custom/V8WindowCustom.cpp

[haraken, 2016-03-14 23:02:21]

binding/ LGTM

[kozy, 2016-03-14 23:26:15]

thanks!

[kozy, 2016-03-14 23:26:19]

The CQ bit was checked by kozyatinskiy@chromium.org

[commit-bot: I haz the power, 2016-03-14 23:26:39]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1798143002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1798143002/1

[commit-bot: I haz the power, 2016-03-15 01:09:12]

Description was changed from

==========
[DevTools] Removed __defineGetter__ from InjectedScriptSource.js

All Command Line API methods were splitted into common methods and getters
methods. V8WindowCustom binding calls getters method by itself.

Check of existance Command Line API method on global object can be removed from
inScopeVariable function inside constructor because V8CustomBinding wouldn't be
called if it's redefined by users.

BUG=593537
R=dgozman@chromium.org, pfeldman@chromium.org
==========

to

==========
[DevTools] Removed __defineGetter__ from InjectedScriptSource.js

All Command Line API methods were splitted into common methods and getters
methods. V8WindowCustom binding calls getters method by itself.

Check of existance Command Line API method on global object can be removed from
inScopeVariable function inside constructor because V8CustomBinding wouldn't be
called if it's redefined by users.

BUG=593537
R=dgozman@chromium.org, pfeldman@chromium.org
==========

[commit-bot: I haz the power, 2016-03-15 01:09:14]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-03-15 01:11:52]

Description was changed from

==========
[DevTools] Removed __defineGetter__ from InjectedScriptSource.js

All Command Line API methods were splitted into common methods and getters
methods. V8WindowCustom binding calls getters method by itself.

Check of existance Command Line API method on global object can be removed from
inScopeVariable function inside constructor because V8CustomBinding wouldn't be
called if it's redefined by users.

BUG=593537
R=dgozman@chromium.org, pfeldman@chromium.org
==========

to

==========
[DevTools] Removed __defineGetter__ from InjectedScriptSource.js

All Command Line API methods were splitted into common methods and getters
methods. V8WindowCustom binding calls getters method by itself.

Check of existance Command Line API method on global object can be removed from
inScopeVariable function inside constructor because V8CustomBinding wouldn't be
called if it's redefined by users.

BUG=593537
R=dgozman@chromium.org, pfeldman@chromium.org

Committed: https://crrev.com/f48b656630e08f24394cf69fea53b4fd2ae0f59f
Cr-Commit-Position: refs/heads/master@{#381143}
==========

[commit-bot: I haz the power, 2016-03-15 01:11:53]

Patchset 1 (id:??) landed as
https://crrev.com/f48b656630e08f24394cf69fea53b4fd2ae0f59f
Cr-Commit-Position: refs/heads/master@{#381143}