Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(221)

Unified Diff: chrome/browser/resources/settings/appearance_page/appearance_page.js

Issue 1798133002: [MD settings] add sub-label to Show Home Button check box (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: review changes Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/resources/settings/appearance_page/appearance_page.html ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/settings/appearance_page/appearance_page.js
diff --git a/chrome/browser/resources/settings/appearance_page/appearance_page.js b/chrome/browser/resources/settings/appearance_page/appearance_page.js
index 22c94b8844b01adda10370469e21ca2c5031ab34..744e7dcd8f0ad0615cf2cc5c724c7615fff88506 100644
--- a/chrome/browser/resources/settings/appearance_page/appearance_page.js
+++ b/chrome/browser/resources/settings/appearance_page/appearance_page.js
@@ -130,6 +130,20 @@ Polymer({
},
/**
+ * @param {boolean} isNtp Whether to use the NTP as the home page.
+ * @param {string} homepage If not using NTP, use this URL.
+ * @return {string} The sub-label.
+ * @private
+ */
+ getShowHomeSubLabel_: function(isNtp, homepage) {
+ if (isNtp)
+ return this.i18n('homePageNtp');
+ if (homepage.length == 0)
+ return this.i18n('exampleDotCom');
+ return homepage;
Dan Beam 2016/03/16 00:12:14 arguable nit: return homepage || this.i18n('exampl
dschuyler 2016/03/16 21:02:07 Done.
+ },
+
+ /**
* @param {boolean} enabled Whether the theme reset is available.
*/
setResetThemeEnabled: function(enabled) {
« no previous file with comments | « chrome/browser/resources/settings/appearance_page/appearance_page.html ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698