[MD settings] add sub-label to Show Home Button check box

[MD settings] add sub-label to Show Home Button check box

BUG=589630
Committed: https://crrev.com/43d09d7e7c52c76dbec6d81fce8a5a8e6117efc1
Cr-Commit-Position: refs/heads/master@{#381754}

[dschuyler, 2016-03-14 18:48:04]

dschuyler@chromium.org changed reviewers:
+ dpapad@chromium.org

[dschuyler, 2016-03-14 18:48:05]

Screen shots at http://imgur.com/a/gjlPS

[dpapad, 2016-03-14 21:33:26]

https://codereview.chromium.org/1798133002/diff/20001/chrome/browser/resource...
File chrome/browser/resources/settings/appearance_page/appearance_page.js
(right):

https://codereview.chromium.org/1798133002/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/appearance_page/appearance_page.js:135: *
@private {string} The sub-label.
Did you mean this?

* @return {string} The sub-label.
* @private

https://codereview.chromium.org/1798133002/diff/20001/chrome/browser/resource...
File chrome/browser/resources/settings/appearance_page/compiled_resources2.gyp
(right):

https://codereview.chromium.org/1798133002/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/appearance_page/compiled_resources2.gyp:18:
'<(DEPTH)/ui/webui/resources/js/compiled_resources2.gyp:assert'
Is this necessary? I don't see any assert() call in appearance_page.js.

[dschuyler, 2016-03-14 22:42:25]

https://codereview.chromium.org/1798133002/diff/20001/chrome/browser/resource...
File chrome/browser/resources/settings/appearance_page/appearance_page.js
(right):

https://codereview.chromium.org/1798133002/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/appearance_page/appearance_page.js:135: *
@private {string} The sub-label.
On 2016/03/14 21:33:26, dpapad wrote:
> Did you mean this?
> 
> * @return {string} The sub-label.
> * @private

Thanks!

https://codereview.chromium.org/1798133002/diff/20001/chrome/browser/resource...
File chrome/browser/resources/settings/appearance_page/compiled_resources2.gyp
(right):

https://codereview.chromium.org/1798133002/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/appearance_page/compiled_resources2.gyp:18:
'<(DEPTH)/ui/webui/resources/js/compiled_resources2.gyp:assert'
On 2016/03/14 21:33:26, dpapad wrote:
> Is this necessary? I don't see any assert() call in appearance_page.js.

It's necessary for a different CL that is not this CL.
i.e. this is a whoops to be in this CL.  thanks

[dpapad, 2016-03-14 23:01:43]

lgtm

[Dan Beam, 2016-03-14 23:03:23]

dbeam@chromium.org changed reviewers:
+ dbeam@chromium.org

[Dan Beam, 2016-03-14 23:03:23]

can you add a BUG= to this CL?

[dschuyler, 2016-03-14 23:44:38]

Description was changed from

==========
[MD settings] add sub-label to Show Home Button check box

BUG=
==========

to

==========
[MD settings] add sub-label to Show Home Button check box

BUG=589630
==========

[dschuyler, 2016-03-14 23:45:14]

On 2016/03/14 23:03:23, Dan Beam wrote:
> can you add a BUG= to this CL?

done.

[Dan Beam, 2016-03-16 00:12:15]

fyi, the review system automatically adds people as reviewers when they comment
(by default)

so if I comment, and I'm not a reviewer, it's unlikely:
a) I meant to do that
b) you need to wait on it

either way: if you're waiting on me, lgtm

https://codereview.chromium.org/1798133002/diff/40001/chrome/browser/resource...
File chrome/browser/resources/settings/appearance_page/appearance_page.js
(right):

https://codereview.chromium.org/1798133002/diff/40001/chrome/browser/resource...
chrome/browser/resources/settings/appearance_page/appearance_page.js:143: return
homepage;
arguable nit: return homepage || this.i18n('exampleDotCom');

[dschuyler, 2016-03-16 21:02:07]

https://codereview.chromium.org/1798133002/diff/40001/chrome/browser/resource...
File chrome/browser/resources/settings/appearance_page/appearance_page.js
(right):

https://codereview.chromium.org/1798133002/diff/40001/chrome/browser/resource...
chrome/browser/resources/settings/appearance_page/appearance_page.js:143: return
homepage;
On 2016/03/16 00:12:14, Dan Beam wrote:
> arguable nit: return homepage || this.i18n('exampleDotCom');

Done.

[dschuyler, 2016-03-17 18:25:37]

The CQ bit was checked by dschuyler@chromium.org

[dschuyler, 2016-03-17 18:25:38]

The patchset sent to the CQ was uploaded after l-g-t-m from dbeam@chromium.org,
dpapad@chromium.org
Link to the patchset: https://codereview.chromium.org/1798133002/#ps60001
(title: "review nit")

[commit-bot: I haz the power, 2016-03-17 18:26:13]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1798133002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1798133002/60001

[commit-bot: I haz the power, 2016-03-17 18:32:40]

Description was changed from

==========
[MD settings] add sub-label to Show Home Button check box

BUG=589630
==========

to

==========
[MD settings] add sub-label to Show Home Button check box

BUG=589630
==========

[commit-bot: I haz the power, 2016-03-17 18:32:41]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-03-17 18:34:01]

Description was changed from

==========
[MD settings] add sub-label to Show Home Button check box

BUG=589630
==========

to

==========
[MD settings] add sub-label to Show Home Button check box

BUG=589630

Committed: https://crrev.com/43d09d7e7c52c76dbec6d81fce8a5a8e6117efc1
Cr-Commit-Position: refs/heads/master@{#381754}
==========

[commit-bot: I haz the power, 2016-03-17 18:34:02]

Patchset 4 (id:??) landed as
https://crrev.com/43d09d7e7c52c76dbec6d81fce8a5a8e6117efc1
Cr-Commit-Position: refs/heads/master@{#381754}