Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 179813009: Revert of Reland "Add base::TimeDelta::Max()" (Closed)

Created:
6 years, 9 months ago by apavlov
Modified:
6 years, 9 months ago
CC:
chromium-reviews, tim+watch_chromium.org, cbentzel+watch_chromium.org, fischman+watch_chromium.org, haitaol+watch_chromium.org, jam, mcasas+watch_chromium.org, joi+watch-content_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, cc-bugs_chromium.org, erikwright+watch_chromium.org, wjia+watch_chromium.org, maniscalco+watch_chromium.org
Visibility:
Public.

Description

Revert of Reland "Add base::TimeDelta::Max()" (https://codereview.chromium.org/183763011/) Reason for revert: http/tests/media/video-cookie.html is asserting on debug bots Original issue's description: > Reland "Add base::TimeDelta::Max()" > > Media was exposing max timedeltas to JSON, which wasn't working with > infinity. > > R=scherkus@chromium.org > TBR=ajwong@chromium.org,jar@chromium.org,jamesr@chomium.org,acolwell@chromium.org,nick@chromium.org > BUG=None > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=254717 TBR=ajwong@chromium.org,jar@chromium.org,scherkus@chromium.org,jamesr@chomium.org,acolwell@chromium.org,nick@chromium.org,gavinp@chromium.org NOTREECHECKS=true NOTRY=true BUG=None Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=254743

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -131 lines) Patch
M base/time/time.h View 3 chunks +6 lines, -34 lines 0 comments Download
M base/time/time.cc View 1 chunk +0 lines, -41 lines 0 comments Download
M base/time/time_unittest.cc View 1 chunk +0 lines, -40 lines 0 comments Download
M cc/debug/rasterize_and_record_benchmark.cc View 1 chunk +2 lines, -1 line 0 comments Download
M cc/debug/rasterize_and_record_benchmark_impl.cc View 1 chunk +2 lines, -1 line 0 comments Download
M cc/resources/picture_pile.cc View 1 chunk +2 lines, -1 line 0 comments Download
M cc/resources/picture_pile_impl.cc View 1 chunk +2 lines, -1 line 0 comments Download
M content/renderer/media/websourcebuffer_impl.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M media/base/buffers.h View 1 chunk +1 line, -1 line 0 comments Download
M media/base/media_log.cc View 1 chunk +1 line, -4 lines 0 comments Download
M media/filters/chunk_demuxer.cc View 1 chunk +0 lines, -1 line 0 comments Download
M net/http/http_response_headers.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/spdy/spdy_session.cc View 1 chunk +3 lines, -1 line 0 comments Download
M sync/sessions/nudge_tracker.cc View 2 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
apavlov
Created Revert of Reland "Add base::TimeDelta::Max()"
6 years, 9 months ago (2014-03-04 10:57:30 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/apavlov@chromium.org/179813009/1
6 years, 9 months ago (2014-03-04 10:57:52 UTC) #2
apavlov
For the reference, see http://test-results.appspot.com/dashboards/flakiness_dashboard.html#group=%40ToT%20Blink&showExpectations=true&tests=http%2Ftests%2Fmedia%2Fvideo-cookie.html
6 years, 9 months ago (2014-03-04 10:58:10 UTC) #3
commit-bot: I haz the power
6 years, 9 months ago (2014-03-04 10:58:18 UTC) #4
Message was sent while issue was closed.
Change committed as 254743

Powered by Google App Engine
This is Rietveld 408576698