Move PolicyLoaderMac::CreateValueFromProperty to a generic file.

Move PolicyLoaderMac::CreateValueFromProperty to a generic file.

This function converts a CFPropertyListRef to the equivalent base::Value.
This change moves that function to mac_util.h so that it can be reused on
iOS.

This change also moves a helper function that does the reverse conversion
for tests.

BUG=348820
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=254967

[Joao da Silva, 2014-03-04 01:35:18]

PTAL, thanks!

Jochen: components_tests.gyp owner check

Daniel: whole thing

[Joao da Silva, 2014-03-04 14:49:32]

+Jói: please review components_tests.gyp, thanks!

[Jói, 2014-03-04 14:57:37]

components_tests.gyp LGTM

[dconnelly, 2014-03-04 21:13:36]

lgtm

https://codereview.chromium.org/179813008/diff/20001/components/policy/core/c...
File components/policy/core/common/mac_util.h (right):

https://codereview.chromium.org/179813008/diff/20001/components/policy/core/c...
components/policy/core/common/mac_util.h:22: // entries whose key is not a
CFStringRef are ignored.
why?

[Joao da Silva, 2014-03-04 23:18:01]

Thanks for the reviews!

https://codereview.chromium.org/179813008/diff/20001/components/policy/core/c...
File components/policy/core/common/mac_util.h (right):

https://codereview.chromium.org/179813008/diff/20001/components/policy/core/c...
components/policy/core/common/mac_util.h:22: // entries whose key is not a
CFStringRef are ignored.
On 2014/03/04 21:13:36, dconnelly wrote:
> why?

Because that's supported in CFDictionaries but not in base::DictionaryValues.

The Chrome app manifest (which declares the supported managed settings on Mac)
restricts the keys to strings, so no valid policy configuration will have
anything other than strings as keys.

[Joao da Silva, 2014-03-04 23:18:07]

The CQ bit was checked by joaodasilva@chromium.org

[commit-bot: I haz the power, 2014-03-04 23:18:38]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/joaodasilva@chromium.org/179813008/20001

[commit-bot: I haz the power, 2014-03-05 01:13:34]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/joaodasilva@chromium.org/179813008/20001

[commit-bot: I haz the power, 2014-03-05 07:05:59]

Change committed as 254967