Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Side by Side Diff: src/ia32/assembler-ia32.cc

Issue 179813005: Special case the recording of constant pool entries in the slot buffer. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Remove VisitCodeTarget(Address) function Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/assembler.h ('k') | src/ia32/assembler-ia32-inl.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 1994-2006 Sun Microsystems Inc. 1 // Copyright (c) 1994-2006 Sun Microsystems Inc.
2 // All Rights Reserved. 2 // All Rights Reserved.
3 // 3 //
4 // Redistribution and use in source and binary forms, with or without 4 // Redistribution and use in source and binary forms, with or without
5 // modification, are permitted provided that the following conditions 5 // modification, are permitted provided that the following conditions
6 // are met: 6 // are met:
7 // 7 //
8 // - Redistributions of source code must retain the above copyright notice, 8 // - Redistributions of source code must retain the above copyright notice,
9 // this list of conditions and the following disclaimer. 9 // this list of conditions and the following disclaimer.
10 // 10 //
(...skipping 142 matching lines...) Expand 10 before | Expand all | Expand 10 after
153 153
154 bool RelocInfo::IsCodedSpecially() { 154 bool RelocInfo::IsCodedSpecially() {
155 // The deserializer needs to know whether a pointer is specially coded. Being 155 // The deserializer needs to know whether a pointer is specially coded. Being
156 // specially coded on IA32 means that it is a relative address, as used by 156 // specially coded on IA32 means that it is a relative address, as used by
157 // branch instructions. These are also the ones that need changing when a 157 // branch instructions. These are also the ones that need changing when a
158 // code object moves. 158 // code object moves.
159 return (1 << rmode_) & kApplyMask; 159 return (1 << rmode_) & kApplyMask;
160 } 160 }
161 161
162 162
163 bool RelocInfo::IsInConstantPool() {
164 return false;
165 }
166
167
163 void RelocInfo::PatchCode(byte* instructions, int instruction_count) { 168 void RelocInfo::PatchCode(byte* instructions, int instruction_count) {
164 // Patch the code at the current address with the supplied instructions. 169 // Patch the code at the current address with the supplied instructions.
165 for (int i = 0; i < instruction_count; i++) { 170 for (int i = 0; i < instruction_count; i++) {
166 *(pc_ + i) = *(instructions + i); 171 *(pc_ + i) = *(instructions + i);
167 } 172 }
168 173
169 // Indicate that code has changed. 174 // Indicate that code has changed.
170 CPU::FlushICache(pc_, instruction_count); 175 CPU::FlushICache(pc_, instruction_count);
171 } 176 }
172 177
(...skipping 2560 matching lines...) Expand 10 before | Expand all | Expand 10 after
2733 fprintf(coverage_log, "%s\n", file_line); 2738 fprintf(coverage_log, "%s\n", file_line);
2734 fflush(coverage_log); 2739 fflush(coverage_log);
2735 } 2740 }
2736 } 2741 }
2737 2742
2738 #endif 2743 #endif
2739 2744
2740 } } // namespace v8::internal 2745 } } // namespace v8::internal
2741 2746
2742 #endif // V8_TARGET_ARCH_IA32 2747 #endif // V8_TARGET_ARCH_IA32
OLDNEW
« no previous file with comments | « src/assembler.h ('k') | src/ia32/assembler-ia32-inl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698