Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Side by Side Diff: src/arm/assembler-arm-inl.h

Issue 179813005: Special case the recording of constant pool entries in the slot buffer. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Remove VisitCodeTarget(Address) function Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/arm/assembler-arm.cc ('k') | src/assembler.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 1994-2006 Sun Microsystems Inc. 1 // Copyright (c) 1994-2006 Sun Microsystems Inc.
2 // All Rights Reserved. 2 // All Rights Reserved.
3 // 3 //
4 // Redistribution and use in source and binary forms, with or without 4 // Redistribution and use in source and binary forms, with or without
5 // modification, are permitted provided that the following conditions 5 // modification, are permitted provided that the following conditions
6 // are met: 6 // are met:
7 // 7 //
8 // - Redistributions of source code must retain the above copyright notice, 8 // - Redistributions of source code must retain the above copyright notice,
9 // this list of conditions and the following disclaimer. 9 // this list of conditions and the following disclaimer.
10 // 10 //
(...skipping 95 matching lines...) Expand 10 before | Expand all | Expand 10 after
106 106
107 107
108 Address RelocInfo::target_address_address() { 108 Address RelocInfo::target_address_address() {
109 ASSERT(IsCodeTarget(rmode_) || IsRuntimeEntry(rmode_) 109 ASSERT(IsCodeTarget(rmode_) || IsRuntimeEntry(rmode_)
110 || rmode_ == EMBEDDED_OBJECT 110 || rmode_ == EMBEDDED_OBJECT
111 || rmode_ == EXTERNAL_REFERENCE); 111 || rmode_ == EXTERNAL_REFERENCE);
112 return Assembler::target_pointer_address_at(pc_); 112 return Assembler::target_pointer_address_at(pc_);
113 } 113 }
114 114
115 115
116 Address RelocInfo::constant_pool_entry_address() {
117 ASSERT(IsInConstantPool());
118 ASSERT(Assembler::IsLdrPcImmediateOffset(Memory::int32_at(pc_)));
119 return Assembler::target_pointer_address_at(pc_);
120 }
121
122
116 int RelocInfo::target_address_size() { 123 int RelocInfo::target_address_size() {
117 return kPointerSize; 124 return kPointerSize;
118 } 125 }
119 126
120 127
121 void RelocInfo::set_target_address(Address target, WriteBarrierMode mode) { 128 void RelocInfo::set_target_address(Address target, WriteBarrierMode mode) {
122 ASSERT(IsCodeTarget(rmode_) || IsRuntimeEntry(rmode_)); 129 ASSERT(IsCodeTarget(rmode_) || IsRuntimeEntry(rmode_));
123 Assembler::set_target_address_at(pc_, target); 130 Assembler::set_target_address_at(pc_, target);
124 if (mode == UPDATE_WRITE_BARRIER && host() != NULL && IsCodeTarget(rmode_)) { 131 if (mode == UPDATE_WRITE_BARRIER && host() != NULL && IsCodeTarget(rmode_)) {
125 Object* target_code = Code::GetCodeFromTargetAddress(target); 132 Object* target_code = Code::GetCodeFromTargetAddress(target);
(...skipping 364 matching lines...) Expand 10 before | Expand all | Expand 10 after
490 // ldr ip, [pc, #...] 497 // ldr ip, [pc, #...]
491 // since the instruction accessing this address in the constant pool remains 498 // since the instruction accessing this address in the constant pool remains
492 // unchanged. 499 // unchanged.
493 } 500 }
494 } 501 }
495 502
496 503
497 } } // namespace v8::internal 504 } } // namespace v8::internal
498 505
499 #endif // V8_ARM_ASSEMBLER_ARM_INL_H_ 506 #endif // V8_ARM_ASSEMBLER_ARM_INL_H_
OLDNEW
« no previous file with comments | « src/arm/assembler-arm.cc ('k') | src/assembler.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698