Special case the recording of constant pool entries in the slot buffer.

src/objects.cc

 // Copyright 2013 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 10241 matching lines @@
 
 
 #define DECLARE_TAG(ignore1, ignore2, name) name,
 const char* const VisitorSynchronization::kTagNames[
     VisitorSynchronization::kNumberOfSyncTags] = {
   VISITOR_SYNCHRONIZATION_TAGS_LIST(DECLARE_TAG)
 };
 #undef DECLARE_TAG
 
 
-void ObjectVisitor::VisitCodeTarget(RelocInfo* rinfo) {
-  ASSERT(RelocInfo::IsCodeTarget(rinfo->rmode()));
-  Object* target = Code::GetCodeFromTargetAddress(rinfo->target_address());
+void ObjectVisitor::VisitCodeTargetCommon(Address target_address) {

[Michael Starzinger, 2014/03/07 14:36:59]

IMHO, the logic in here is small enough so that we can inline into the two
callers and get rid of the common helper. I think that's easier to read.

[rmcilroy, 2014/03/10 12:25:23]

Removed VisitCodeTarget(Address) as discussed, so no longer applicable.

+  Object* target = Code::GetCodeFromTargetAddress(target_address);
   Object* old_target = target;
   VisitPointer(&target);
   CHECK_EQ(target, old_target);  // VisitPointer doesn't change Code* *target.
 }
 
 
+void ObjectVisitor::VisitCodeTarget(RelocInfo* rinfo) {
+  ASSERT(RelocInfo::IsCodeTarget(rinfo->rmode()));
+  VisitCodeTargetCommon(rinfo->target_address());
+}
+
+
+void ObjectVisitor::VisitCodeTarget(Address target_address_pointer) {
+  VisitCodeTargetCommon(Memory::Address_at(target_address_pointer));
+}
+
+
 void ObjectVisitor::VisitCodeAgeSequence(RelocInfo* rinfo) {
   ASSERT(RelocInfo::IsCodeAgeSequence(rinfo->rmode()));
   Object* stub = rinfo->code_age_stub();
   if (stub) {
     VisitPointer(&stub);
   }
 }
 
 
 void ObjectVisitor::VisitCodeEntry(Address entry_address) {
@@ skipping 6202 matching lines @@
 #define ERROR_MESSAGES_TEXTS(C, T) T,
   static const char* error_messages_[] = {
       ERROR_MESSAGES_LIST(ERROR_MESSAGES_TEXTS)
   };
 #undef ERROR_MESSAGES_TEXTS
   return error_messages_[reason];
 }
 
 
 } }  // namespace v8::internal