Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 1798113002: Switch StoragePartitionService interface to use url::Origin instead of mojo string. (Closed)

Created:
4 years, 9 months ago by jam
Modified:
4 years, 9 months ago
CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, chromium-reviews, darin (slow to review), darin-cc_chromium.org, jam, mkwst+moarreviews-renderer_chromium.org, mlamouri+watch-content_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, wjmaclean, yzshen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Switch StoragePartitionService interface to use url::Origin instead of mojo string. BUG=586194 Committed: https://crrev.com/3643404f71aa094be5ab2453d6b01a1ab2c1b97b Cr-Commit-Position: refs/heads/master@{#381229}

Patch Set 1 #

Patch Set 2 : fix gyp #

Patch Set 3 : fix android builds per Ken #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -12 lines) Patch
M content/browser/dom_storage/dom_storage_context_wrapper.h View 3 chunks +4 lines, -3 lines 0 comments Download
M content/browser/dom_storage/dom_storage_context_wrapper.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M content/browser/storage_partition_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/storage_partition_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/common/BUILD.gn View 1 chunk +3 lines, -0 lines 0 comments Download
M content/common/storage_partition_service.mojom View 1 chunk +2 lines, -1 line 0 comments Download
M content/content_common_mojo_bindings.gyp View 1 2 chunks +7 lines, -0 lines 0 comments Download
M content/renderer/dom_storage/local_storage_cached_area.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/tools/bindings/mojom.gni View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 19 (8 generated)
jam
4 years, 9 months ago (2016-03-14 21:54:41 UTC) #3
jam
+rockot for mojo/public/tools/bindings/mojom.gni
4 years, 9 months ago (2016-03-14 21:55:50 UTC) #5
Ken Rockot(use gerrit already)
gni lgtm
4 years, 9 months ago (2016-03-14 21:59:01 UTC) #6
michaeln
lgtm 2
4 years, 9 months ago (2016-03-14 22:27:21 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1798113002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1798113002/60001
4 years, 9 months ago (2016-03-15 04:24:22 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/157050)
4 years, 9 months ago (2016-03-15 04:33:49 UTC) #11
jam
+dcheng for mojom change
4 years, 9 months ago (2016-03-15 04:41:19 UTC) #13
dcheng
lgtm
4 years, 9 months ago (2016-03-15 05:28:25 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1798113002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1798113002/60001
4 years, 9 months ago (2016-03-15 16:12:46 UTC) #16
commit-bot: I haz the power
Committed patchset #3 (id:60001)
4 years, 9 months ago (2016-03-15 16:17:19 UTC) #17
commit-bot: I haz the power
4 years, 9 months ago (2016-03-15 16:18:57 UTC) #19
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/3643404f71aa094be5ab2453d6b01a1ab2c1b97b
Cr-Commit-Position: refs/heads/master@{#381229}

Powered by Google App Engine
This is Rietveld 408576698