Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(236)

Side by Side Diff: build/config/compiler/compiler.gni

Issue 1798093002: [Chromecast] Set symbol_level=2 for Chromecast builds by default. (Closed) Base URL: https://chromium.googlesource.com/chromium/src@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2015 The Chromium Authors. All rights reserved. 1 # Copyright 2015 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//build/config/android/config.gni") 5 import("//build/config/android/config.gni")
6 import("//build/config/chrome_build.gni") 6 import("//build/config/chrome_build.gni")
7 import("//build/config/chromecast_build.gni")
7 import("//build/config/sanitizers/sanitizers.gni") 8 import("//build/config/sanitizers/sanitizers.gni")
8 9
9 declare_args() { 10 declare_args() {
10 # How many symbols to include in the build. This affects the performance of 11 # How many symbols to include in the build. This affects the performance of
11 # the build since the symbols are large and dealing with them is slow. 12 # the build since the symbols are large and dealing with them is slow.
12 # 2 means regular build with symbols. 13 # 2 means regular build with symbols.
13 # 1 means minimal symbols, usually enough for backtraces only. 14 # 1 means minimal symbols, usually enough for backtraces only.
14 # 0 means no symbols. 15 # 0 means no symbols.
15 # -1 means auto-set according to debug/release and platform. 16 # -1 means auto-set according to debug/release and platform.
16 symbol_level = -1 17 symbol_level = -1
17 18
18 # Compile in such a way as to enable profiling of the generated code. For 19 # Compile in such a way as to enable profiling of the generated code. For
19 # example, don't omit the frame pointer and leave in symbols. 20 # example, don't omit the frame pointer and leave in symbols.
20 enable_profiling = false 21 enable_profiling = false
21 } 22 }
22 23
23 # If it wasn't manually set, set to an appropriate default. 24 # If it wasn't manually set, set to an appropriate default.
24 assert(symbol_level >= -1 && symbol_level <= 2, "Invalid symbol_level") 25 assert(symbol_level >= -1 && symbol_level <= 2, "Invalid symbol_level")
25 if (symbol_level == -1) { 26 if (symbol_level == -1) {
26 if (is_android && use_order_profiling) { 27 if (is_android && use_order_profiling) {
27 # With instrumentation enabled, debug info puts libchrome.so over 4gb, which 28 # With instrumentation enabled, debug info puts libchrome.so over 4gb, which
28 # causes the linker to produce an invalid ELF. http://crbug.com/574476 29 # causes the linker to produce an invalid ELF. http://crbug.com/574476
29 symbol_level = 0 30 symbol_level = 0
30 } else if (!is_linux || (is_debug || is_official_build)) { 31 } else if (!is_linux || is_debug || is_official_build || is_chromecast) {
alokp 2016/03/14 16:48:23 This is OK, but can you explain what is wrong with
slan 2016/03/14 17:00:36 This solution also ensures this behavior on Androi
alokp 2016/03/14 17:13:53 I am assuming that this only affects Eng builds, r
31 # Linux is slowed by having symbols as part of the target binary, whereas 32 # Linux is slowed by having symbols as part of the target binary, whereas
32 # Mac and Windows have them separate, so in Release Linux, default them off, 33 # Mac and Windows have them separate, so in Release Linux, default them off,
33 # but keep them on for Official builds. 34 # but keep them on for Official builds and Chromecast builds.
34 symbol_level = 2 35 symbol_level = 2
35 } else if (using_sanitizer) { 36 } else if (using_sanitizer) {
36 # Sanitizers require symbols for filename suppressions to work. 37 # Sanitizers require symbols for filename suppressions to work.
37 symbol_level = 1 38 symbol_level = 1
38 } else { 39 } else {
39 symbol_level = 0 40 symbol_level = 0
40 } 41 }
41 } 42 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698